use conditions instead of criteria as workaround #18294
Conversation
atomfrede
force-pushed
the
18269-workaround-removal-of-criteria
branch
from
5a37a9f
to
c220a21
Compare
| } else { | ||
| return createSelectImpl(selectFrom.limitOffset(pageable.getPageSize(), pageable.getOffset()), entityType, pageable.getSort()); | ||
| } | ||
| return createSelectImpl(selectFrom.limitOffset(pageable.getPageSize(), pageable.getOffset()), entityType, pageable.getSort()); |
There was a problem hiding this comment.
should we pass the condition here?
There was a problem hiding this comment.
Yes I think you're right. Hope to be able to update in during lunch.
There was a problem hiding this comment.
I think we can merge once that is done
|
@pascalgrimaud shall I do the release once this is merged? (using your ansible playbook) |
|
@atomfrede @pascalgrimaud I have updated the conditions I'll do some tests and merge once CI is green, let me know if you guys have any objections |
|
Thanks @deepu105. From my point of view we can do the release. Do we need some additional information for the release notes? I updated the security advisoty description yesterday with more information and how to apply a workaround manually and for what too look in the current code. |
|
I think we are good. I checked and updated and cleaned up the advisory as well so we just need to merge, release and publish. I'm currently doing some manual tests with this branch. |
|
Bounty claimed https://opencollective.com/generator-jhipster/expenses/71821 |
|
@atomfrede : approved |
Instead of using criteria for where clause this workaround uses conditions directly where needed (find by id).
closes #18269
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.