Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of the liquibase changelog that creates table #10454

Merged

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Sep 19, 2019

Before:

<!--
        Added the entity XYZ.
    -->
    <changeSet id="20190121114007-1" author="jhipster">
        <createTable tableName="xyz" remarks="abc">
            <column name="id" type="bigint" autoIncrement="${autoIncrement}">
                <constraints primaryKey="true" nullable="false"/>
            </column>
            <column name="code" type="varchar(255)">
                <constraints nullable="false" />
            </column>

            <column name="name" type="varchar(255)">
                <constraints nullable="true" />
            </column>
            <column name="other_table_id" type="bigint">
                <constraints unique="true" nullable="true" uniqueConstraintName="ux_xyz_other_table_id" />
            </column>            <column name="another_table_id" type="bigint">
                <constraints unique="true" nullable="true" uniqueConstraintName="ux_xyz_another_table_id" />
            </column>
            <column name="third_one_id" type="bigint">
                <constraints nullable="false" />
            </column>

            <!-- jhipster-needle-liquibase-add-column - JHipster will add columns here, do not remove-->
        </createTable>

    </changeSet>

After:

<!--
        Added the entity XYZ.
    -->
    <changeSet id="20190121114007-1" author="jhipster">
        <createTable tableName="xyz" remarks="abc">
            <column name="id" type="bigint" autoIncrement="${autoIncrement}">
                <constraints primaryKey="true" nullable="false"/>
            </column>
            <column name="code" type="varchar(255)">
                <constraints nullable="false" />
            </column>
            </column>
            <column name="name" type="varchar(255)">
                <constraints nullable="true" />
            </column>
            <column name="other_table_id" type="bigint">
                <constraints unique="true" nullable="true" uniqueConstraintName="ux_xyz_other_table_id" />
            </column>
            <column name="another_table_id" type="bigint">
                <constraints unique="true" nullable="true" uniqueConstraintName="ux_xyz_another_table_id" />
            </column>
            <column name="third_one_id" type="bigint">
                <constraints nullable="false" />
            </column>
            <!-- jhipster-needle-liquibase-add-column - JHipster will add columns here, do not remove-->
        </createTable>
    </changeSet>
  • Travis tests are green
  • Tests are added where necessary
  • Documentation is added/updated where necessary
  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@DanielFran DanielFran merged commit 063553c into jhipster:master Sep 20, 2019
@jdubois jdubois added this to the 6.3.1 milestone Sep 20, 2019
@murdos murdos deleted the fix-formatting-added_entity_changelog branch September 20, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants