Entity blueprint: allow blueprints to create custom configs. #10163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
force-pushed
the
use_existing_data
branch
from
623e8ec
to
6f31c02
Compare
mshima
force-pushed
the
use_existing_data
branch
2 times, most recently
from
d702234
to
5d0db8b
Compare
mshima
force-pushed
the
use_existing_data
branch
from
5d0db8b
to
9b972fe
Compare
mshima
changed the title
murdos
reviewed
Sep 12, 2019
mshima
force-pushed
the
use_existing_data
branch
from
9b972fe
to
ad584aa
Compare
murdos
approved these changes
Sep 19, 2019
mshima
force-pushed
the
use_existing_data
branch
from
e761d98
to
278f26c
Compare
|
@murdos done. Thanks. |
|
@mshima You need to lint fix the unit test source file, build is failing because of that: https://travis-ci.org/jhipster/generator-jhipster/jobs/587294729 |
Make tests cases more precise by testing keys and values. Co-Authored-By: Aurélien Mino <aurelien.mino@gmail.com> lint fix
mshima
force-pushed
the
use_existing_data
branch
from
278f26c
to
b724cef
Compare
|
@murdos thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10162
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed