Allow an empty language section in extended header encoding. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section 3.2.1 of RFC 8187 specifies that the language is optional in headers using extended encoding. One example given in 3.2.3 looks like: foo: bar; title*=UTF-8''%c2%a3%20and%20%e2%82%ac%20rates (the quotes are necessary delimiters, but the language is optional and in this case missing). This commit adjusts the relevant regular expression to allow an empty string in this segment. https://datatracker.ietf.org/doc/html/rfc8187#section-3.2.1
|
Wow, quick merge! Thanks :) |
|
Thank you! Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section 3.2.1 of RFC 8187 specifies that the language is optional in headers using extended encoding. One example given in section 3.2.3 looks like:
(the quotes are necessary delimiters, but the language is optional and in this case missing).
This PR adjusts the relevant regular expression to allow an empty string in this segment and adds a companion test.