Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies, fix build #653

Merged
merged 2 commits into from Jul 3, 2022
Merged

Update dependencies, fix build #653

merged 2 commits into from Jul 3, 2022

Conversation

elevenfive
Copy link
Contributor

@elevenfive elevenfive commented Jun 13, 2022 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Have run all the tests that don't require a docker instance running. If someone else has one handy and can test this, it would be appreciated!

Fixes #652

@elevenfive elevenfive marked this pull request as ready for review June 13, 2022 22:52
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@elevenfive
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@elevenfive
Copy link
Contributor Author

recheck

@elevenfive elevenfive changed the title Update dependencies Update dependencies, fix build Jun 13, 2022
@eyalbe4 eyalbe4 self-requested a review June 13, 2022 23:05
@elevenfive elevenfive force-pushed the update-dependencies-fix-build branch from 4d3f3fa to 9824a91 Compare June 14, 2022 02:09
@elevenfive elevenfive force-pushed the update-dependencies-fix-build branch from 9824a91 to 69792c4 Compare June 14, 2022 03:44
@alivesubstance
Copy link

Guys, any updates on this PR?

yahavi
yahavi approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elevenfive!

@yahavi yahavi merged commit 9548db6 into jfrog:master Jul 3, 2022
yahavi added a commit to yahavi/build-info that referenced this pull request Jul 3, 2022
@yahavi
Revert "Update dependencies, fix build (jfrog#653)"
2bf7e1f 
This reverts commit 9548db6.
yahavi added a commit that referenced this pull request Jul 3, 2022
@yahavi
Revert "Update dependencies, fix build (#653)"
bf41c53 
This reverts commit 9548db6.
@yahavi
Copy link
Member

yahavi commented Jul 3, 2022 •
edited

@elevenfive,
After merging this PR, I noticed that the publish tasks failed. As a result, I reverted this change.
We'd appreciate it if you could create a new PR after verifying that the publishToMavenLocal task passes.

By the way - what is the original reason that the build failed for you? Did you compile with JDK 8?
Thanks.

@elevenfive
Copy link
Contributor Author

elevenfive commented Jul 4, 2022 •
edited

Hi I was using JDK 11; when attempting ./gradlew build on master, I was getting > Task :build-info-api:compileJava FAILED

When switching to JDK 8 I am able to build current master, thank you!

Upgrading to Gradle 7 was the reason for the publish failure on this branch, sorry for not checking that task!

I will push with Gradle 6 to #659. Gradle 7 migration will be more involved and beyond my current expertise with Gradle plugins.

@elevenfive elevenfive mentioned this pull request Jul 4, 2022
Merged
1 task
@elevenfive elevenfive deleted the update-dependencies-fix-build branch July 4, 2022 20:32
@kilinochi
Copy link

kilinochi commented Jul 6, 2022 •
edited

hello! when you are going to collect new realize ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project has out of date dependencies and './gradlew clean build test' fails
4 participants
@elevenfive @alivesubstance @yahavi @kilinochi