Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "--host" option. #253

Merged
merged 4 commits into from Apr 15, 2019
Merged

Added "--host" option. #253

merged 4 commits into from Apr 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2019

Added a "--host" option that you can use to specify the host (address) that Ecstatic listened to.

@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #253 into master will decrease coverage by 0.09%.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #253     +/-   ##
=======================================
- Coverage   75.09%    75%   -0.1%     
=======================================
  Files          11     11             
  Lines         554    556      +2     
  Branches      127    128      +1     
=======================================
+ Hits          416    417      +1     
  Misses         49     49             
- Partials       89     90      +1
Impacted Files Coverage Δ
lib/bin.js 70.58% <75%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497c664...2ddc390. Read the comment docs.

Copy link
Owner

@jfhbrook jfhbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t look like the env var in the docs is being respected but otherwise this looks ok - I can merge tonight w the fix

@jfhbrook
Copy link
Owner

also add yourself to CONTRIBUTORS if you don’t mind

Copy link
Owner

@jfhbrook jfhbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll try to sanity check and release tonight.

@jfhbrook jfhbrook merged commit f593b84 into jfhbrook:master Apr 15, 2019
@jfhbrook
Copy link
Owner

Published as 4.1.0.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants