-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "--host" option. #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
- Coverage 75.09% 75% -0.1%
=======================================
Files 11 11
Lines 554 556 +2
Branches 127 128 +1
=======================================
+ Hits 416 417 +1
Misses 49 49
- Partials 89 90 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn’t look like the env var in the docs is being respected but otherwise this looks ok - I can merge tonight w the fix
also add yourself to CONTRIBUTORS if you don’t mind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll try to sanity check and release tonight.
Published as 4.1.0. Thanks! |
Added a "--host" option that you can use to specify the host (address) that Ecstatic listened to.