Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the current charset detector actually even work? #244

Open
jfhbrook opened this issue Apr 5, 2019 · 0 comments
Open

Does the current charset detector actually even work? #244

jfhbrook opened this issue Apr 5, 2019 · 0 comments

Comments

@jfhbrook
Copy link
Owner

jfhbrook commented Apr 5, 2019

I have reasons to believe that the charset library that's intended to guess at charsets for content-types is actually just trying to parse them out of the existing content-type mimetype string, and so is effectively a noop.

I figure the way to fix this is:

  1. Create a new charset abstraction that allows the same sort of registration as with mime types
  2. Set up some sane defaults. This will require some research, and the answer might be "none".
  3. Expose this functionality in the middlware/cli APIs and as a property on the ecstatic module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant