Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] What about template page for directory view? #216

Open
mmmm1998 opened this issue Feb 7, 2018 · 0 comments
Open

[Suggestion] What about template page for directory view? #216

mmmm1998 opened this issue Feb 7, 2018 · 0 comments

Comments

@mmmm1998
Copy link
Contributor

mmmm1998 commented Feb 7, 2018

@jfhbrook Now, view directory page generate by concatenation strings, so code for openDir a bit complicated for perception. Maybe better use template page?
For example, concept of part of "handlebars" template page (.hbs) for generation table for directory files.

<table>
  {{#each files}}
    <tr>
      <td>
        <i class="icon {{iconType}}"></i>
      </td>
      <td class="perms">
        <code>{{permissions}}</code>
      </td>
      <td class="file-size">
        <code>{{size}}</code>
      </td>
      <td class="display-name">
        <a href={{href}}>{{name}}</a>
      </td>
    </tr>
  {{/each}}
</table>

In your opinion, whether or not to carry out such a change?
P.S. Adding handlebars requires only 23 additional packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant