Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marked import instead of adding to scripts? #239

Closed
fxck opened this issue May 27, 2020 · 4 comments
Closed

marked import instead of adding to scripts? #239

fxck opened this issue May 27, 2020 · 4 comments
Labels
enhancement Improvement request

Comments

@fxck
Copy link

fxck commented May 27, 2020

I've been looking at this markedjs/marked#1563 shouldn't it now be possible to simply import marked?

@jfcere
Copy link
Owner

jfcere commented Jun 15, 2020

HI @fxck,

Yes you're right, it should be possible to import marked now instead of including the whole bundle file.

@jfcere jfcere added the enhancement Improvement request label Jun 15, 2020
@KimBum
Copy link

KimBum commented Feb 9, 2022

Any update on this topic? Was just scrolling by, while updating and saw that documentation still states to add bundle to scripts.
Either I am missing something or this is closed, since things seem to work fine without it being in scripts list.

@Rambou
Copy link

Rambou commented Jul 13, 2022

Any update?

@jfcere
Copy link
Owner

jfcere commented Nov 17, 2023

As per ngx-markdown v17.0.0 the marked dependency is imported using ECMAScript Modules and won't trigger this warning anymore.

@jfcere jfcere closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement request
Projects
None yet
Development

No branches or pull requests

4 participants