Modifying of HTTP headers in request metadata is no longer possible with Jetty 10

[smitagarg1]

Jetty version(s)
Jetty 10.0.12

I was earlier using jetty version 9.4.43 and had following code to change empty content-type to "application/octet-stream"
in request metadata in order to avoid jetty not supporting empty content type and throwing 400 errors .

Jetty 9 code :
request.getMetaData()
.getFields()
.computeField(HttpHeader.CONTENT_TYPE, (httpHeader, httpFields) ->
new HttpField(httpHeader, MediaType.APPLICATION_OCTET_STREAM));

Jetty 10 : code changes made to use computeField from HttpFields.Mutable
HttpFields.build(request.getMetaData()
.getFields()).computeField(HttpHeader.CONTENT_TYPE, (httpHeader, httpFields) ->
new HttpField(httpHeader, MediaType.APPLICATION_OCTET_STREAM));

But it has started throwing 400 error again .It seems header value is not getting modified to APPLICATION_OCTET_STREAM from empty

Looks somewhat similar to #7818

[joakime]

Why are you doing that?
What goal are you trying to reach?

There are many paths you could have taken, and it seems you chose one of the most difficult paths.

[smitagarg1]

This is how the application has been .My task here only is to upgrade the existing code as per jetty 10 requirements .

[gregw]

@smitagarg1 your code is just creating a new HttpFields instance, but not setting that back on the baseRequest. Try something like:

        MetaData.Request meta = baseRequest.getMetaData();
        HttpFields.Mutable newFields = HttpFields.build(meta.getFields());
        newFields.computeField(HttpHeader.CONTENT_TYPE, (httpHeader, httpFields) ->
            new HttpField(httpHeader, MediaType.APPLICATION_OCTET_STREAM));
        baseRequest.setMetaData(new MetaData.Request(
            meta.getMethod(),
            meta.getURI(),
            meta.getHttpVersion(),
            newFields));

[github-actions]

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

[joakime]

Question answered, closing.