o.e.j.servlet.listener.ContainerInitializer does not respect servlet spec contract for ServletContainerInitializers

[janbartel]

jetty 9.4.x

See #3706.

The premise of the org.eclipse.jetty.servlet.listener.ContainerInitializer according to the comments is to ease using ServletContainerInitializers in embedded scenarios. Unfortunately, it calls the SCI from a ServletContextListener: according to the spec, a ServletContextListener cannot add another ServletContextListener. Thus, an SCI called via the ContainerInitializer will not be able to add a ServletContextListener, as it is perfectly entitled to do.

[gregw]

One solution may be to use a jetty lifecycle listener instead of a ServletContextListener

[joakime]

for embedded-jetty, I would love to see an API like ...

ServletContextHandler context = new ServletContextHandler();
context.addServletContextInitializer(new MySCI());
// other init
context.start();

Then let Jetty work out the internals of how that should come to be.

[gregw]

@lachlan-roberts I think you are already addressing this one in #5840
I think you are just deprecating it rather than fixing it... @janbartel is that OK?

[janbartel]

I'm ok with deprecation if it is entirely removed in jetty-10 and above.

[lachlan-roberts]

ContainerInitializer.ServletContainerInitializerServletContextListener is a public class so we cant just remove it. And we have already done a release of jetty-10, so I think the best thing we can do is deprecate it right now.

[lachlan-roberts]

This has been fixed with PR #5959.