Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing HttpChannel.Listener.onResponseTrailers(Request) #4956

Closed
joakime opened this issue Jun 9, 2020 · 6 comments
Closed

Missing HttpChannel.Listener.onResponseTrailers(Request) #4956

joakime opened this issue Jun 9, 2020 · 6 comments
Assignees

Comments

@joakime
Copy link
Contributor

joakime commented Jun 9, 2020

Jetty version
9.4.29

Description
In the process of implementing ByteCount API for Issue #4954 it was discovered that there is no Response equivalent for the HttpChannel.Listener.onRequestTrailer(Request request) method.

https://github.com/eclipse/jetty.project/blob/77c232aed8a45c818fd27232278d9f95a021095e/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java#L1095-L1102

We should add a HttpChannel.Listener.onResponse(Request request) method.

@joakime joakime added this to In progress in Jetty 9.4.30 Jun 9, 2020
@joakime joakime moved this from In progress to To do in Jetty 9.4.30 Jun 9, 2020
@joakime joakime removed this from To do in Jetty 9.4.30 Jun 10, 2020
@stale
Copy link

stale bot commented Jun 20, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jun 20, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been closed due to it having no activity.

@stale stale bot closed this as completed Jul 21, 2021
@sbordet sbordet reopened this Jul 21, 2021
@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Jul 21, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jul 22, 2022
@joakime joakime removed the Stale For auto-closed stale issues and pull requests label Jul 22, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jul 23, 2023
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jul 23, 2023
@sbordet
Copy link
Contributor

sbordet commented Jul 23, 2023

@lorban can you check what's the status of this issue in Jetty 12?

@lorban
Copy link
Contributor

lorban commented Jul 24, 2023

The 12.0.x EventsHandler has a void onResponseTrailersComplete(Request request, HttpFields trailers) event that should cover this.

@sbordet sbordet closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants