Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientStreamTest.testUploadWithPendingReadConcurrentServerCloseClosesStream(Transport)[3] H2C is flaky #11692

Closed
lorban opened this issue Apr 24, 2024 · 0 comments · Fixed by #11693
Closed

HttpClientStreamTest.testUploadWithPendingReadConcurrentServerCloseClosesStream(Transport)[3] H2C is flaky #11692

lorban opened this issue Apr 24, 2024 · 0 comments · Fixed by #11693
Assignees
@lorban
Labels
flaky-test

Comments

@lorban
Copy link
Contributor

lorban commented Apr 24, 2024

Jetty version(s)
12.0.x

Description
HttpClientStreamTest.testUploadWithPendingReadConcurrentServerCloseClosesStream(Transport)[3] H2C sometimes fails with:

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at org.eclipse.jetty.test.client.transport.HttpClientStreamTest.testUploadWithPendingReadConcurrentServerCloseClosesStream(HttpClientStreamTest.java:1152)

See: https://jenkins.webtide.net/job/jetty.project/job/jetty-12.0.x/1982/testReport/junit/org.eclipse.jetty.test.client.transport/HttpClientStreamTest/Parallel_Stage___Build___Test___JDK22___testUploadWithPendingReadConcurrentServerCloseClosesStream_Transport__3__H2C/
@lorban lorban self-assigned this Apr 24, 2024
lorban added a commit that referenced this issue Apr 24, 2024
@lorban
#11692 fix flaky testUploadWithPendingReadConcurrentServerCloseCloses…
8f84742 
…Stream()

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban mentioned this issue Apr 24, 2024
Merged
lorban added a commit that referenced this issue Apr 26, 2024
@lorban
#11692 alternative fix: run leftover tasks
7596503 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 29, 2024
@lorban
#11692 revert alternative fix and add a comment explaining the situation
c4fade1 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue May 2, 2024
@lorban
Fix flaky `testUploadWithPendingReadConcurrentServerCloseClosesStream…
cfee4fe 
…()` (#11693)

* #11692 fix flaky testUploadWithPendingReadConcurrentServerCloseClosesStream()

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
flaky-test
Projects
Jetty 12.0.10
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky testUploadWithPendingReadConcurrentServerCloseClosesStream() jetty/jetty.project
1 participant
@lorban