Flaky distribution tests in jetty-12

[gregw]

Jetty version(s)
12
Jetty Environment
all

Description

We have many distribution tests that do something like:

                    assertTrue(run3.awaitConsoleLogsFor("Started oejs.Server@", START_TIMEOUT, TimeUnit.SECONDS));
                    ContentResponse response = client.GET("http://localhost:" + port + "/test/sometest.txt");

However, the "Started" log is emitted whilst the context is still Starting, so if the client response is quick it will arrive at the context and be handled by:

        if (handler == null || !isStarted())
            return false;

So the client loses the race and the request is 404'd

A fix for this is to turn on debug for the deployer and wait like:

                // Wait for start context
                assertTrue(run2.awaitConsoleLogsFor("Started oeje10w.WebAppContext@", START_TIMEOUT, TimeUnit.SECONDS));
                // wait for deployer node to complete so context is Started not Starting
                assertTrue(run2.awaitConsoleLogsFor("Executing Node Node[started]", START_TIMEOUT, TimeUnit.SECONDS));
                ContentResponse response = client.GET("http://localhost:" + port + "/test/sometest.txt");