Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathMappingsHandler exposes PathSpec and Context based on PathSpec #11494

Open
joakime opened this issue Mar 7, 2024 · 0 comments · May be fixed by #11497
Open

PathMappingsHandler exposes PathSpec and Context based on PathSpec #11494

joakime opened this issue Mar 7, 2024 · 0 comments · May be fixed by #11497
Assignees

Comments

@joakime
Copy link
Contributor

joakime commented Mar 7, 2024

Jetty version(s)
12.0.7

Enhancement Description
The existing PathMappingsHandler does not record the matched PathSpec that lead to the decision to call the specific handler.

I propose we add the matched PathSpec to the Request attributes before calling the matched Handler.

This has 2 benefits.

  1. The PathSpec details (like regex matched groupings, and uri-template variables / path-params, path-info, etc) can be obtained.
  2. The Request.getPathInContext(Request) can participate in the smart resolution of path-in-context from the matched PathSpec (as a primary source if a ContextHandler is not present?)
joakime added a commit that referenced this issue Mar 7, 2024
@joakime joakime changed the title PathMappingsHandler records matched PathSpec in Request Attributes PathMappingsHandler exposes PathSpec and Context based on PathSpec Mar 7, 2024
@joakime joakime self-assigned this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
1 participant