From a342776c712f51a1ce420530c45a1bddf653bcb7 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Tue, 14 Sep 2021 15:31:55 +1000 Subject: [PATCH] Issue #3514 interpolation of versions from pom in mod files Signed-off-by: Olivier Lamy --- .../jetty-gcloud-session-manager/pom.xml | 19 +-- .../src/main/assembly/config.xml | 2 +- .../session-store-hazelcast-embedded.mod | 2 +- .../session-store-hazelcast-remote.mod | 2 +- jetty-home/pom.xml | 46 ++++++ .../src/main/resources/modules/conscrypt.mod | 2 +- .../src/main/resources/modules/hawtio.mod | 2 +- .../src/main/resources/modules/jamon.mod | 7 +- .../src/main/resources/modules/jolokia.mod | 5 +- .../main/resources/modules/logging-jul.mod | 2 +- .../main/resources/modules/logging-log4j1.mod | 2 +- .../main/resources/modules/logging-log4j2.mod | 2 +- .../resources/modules/logging-logback.mod | 2 +- .../main/resources/modules/logging/slf4j.mod | 2 +- .../sessions/infinispan/infinispan-common.mod | 2 +- .../infinispan-embedded-query/pom.xml | 19 +-- .../src/main/assembly/config.xml | 2 +- .../session-store-infinispan-embedded.mod | 2 +- .../infinispan-remote-query/pom.xml | 19 +-- .../src/main/assembly/config.xml | 2 +- jetty-infinispan/infinispan-remote/pom.xml | 20 +-- .../src/main/assembly/config.xml | 2 +- .../session-store-infinispan-remote.mod | 2 +- .../jetty-unixsocket-server/pom.xml | 21 +-- .../src/main/assembly/config.xml | 4 +- pom.xml | 147 +++++++++++++++++- 26 files changed, 225 insertions(+), 114 deletions(-) diff --git a/jetty-gcloud/jetty-gcloud-session-manager/pom.xml b/jetty-gcloud/jetty-gcloud-session-manager/pom.xml index 59664838eddb..6282b856208a 100644 --- a/jetty-gcloud/jetty-gcloud-session-manager/pom.xml +++ b/jetty-gcloud/jetty-gcloud-session-manager/pom.xml @@ -140,7 +140,7 @@ - + @@ -148,23 +148,6 @@ - - org.apache.maven.plugins - maven-assembly-plugin - - - package - - single - - - - src/main/assembly/config.xml - - - - - diff --git a/jetty-gcloud/jetty-gcloud-session-manager/src/main/assembly/config.xml b/jetty-gcloud/jetty-gcloud-session-manager/src/main/assembly/config.xml index 29e5be1228af..5b9f812e8004 100644 --- a/jetty-gcloud/jetty-gcloud-session-manager/src/main/assembly/config.xml +++ b/jetty-gcloud/jetty-gcloud-session-manager/src/main/assembly/config.xml @@ -7,7 +7,7 @@ - src/main/config-template + target/jetty-config-files ** diff --git a/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-embedded.mod b/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-embedded.mod index b575db5cdc76..3e65e85df246 100644 --- a/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-embedded.mod +++ b/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-embedded.mod @@ -23,7 +23,7 @@ lib/jetty-hazelcast-${jetty.version}.jar lib/hazelcast/hazelcast-${hazelcast.version}.jar [ini] -hazelcast.version?=4.2.2 +hazelcast.version?=@hazelcast.version@ [license] Hazelcast is an open source project hosted on Github and released under the Apache 2.0 license. diff --git a/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-remote.mod b/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-remote.mod index 500e2a5ed8f7..7842d1a1dbb3 100644 --- a/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-remote.mod +++ b/jetty-hazelcast/src/main/config/modules/session-store-hazelcast-remote.mod @@ -23,7 +23,7 @@ lib/jetty-hazelcast-${jetty.version}.jar lib/hazelcast/hazelcast-${hazelcast.version}.jar [ini] -hazelcast.version?=4.2.2 +hazelcast.version?=@hazelcast.version@ [license] Hazelcast is an open source project hosted on Github and released under the Apache 2.0 license. diff --git a/jetty-home/pom.xml b/jetty-home/pom.xml index ce50f73654b2..4ddd092dc108 100644 --- a/jetty-home/pom.xml +++ b/jetty-home/pom.xml @@ -33,9 +33,15 @@ false true ${assembly-directory} + UTF-8 + false + + @ + ${basedir}/src/main/resources + true @@ -865,6 +871,46 @@ jar true + + + io.hawt + hawtio-default + ${hawtio.version} + war + true + + + com.jamonapi + jamon + true + + + com.jamonapi + jamon_war + true + war + + + org.jolokia + jolokia-war + true + war + + + log4j + log4j + true + + + org.apache.logging.log4j + log4j-api + true + + + ch.qos.logback + logback-core + true + diff --git a/jetty-home/src/main/resources/modules/conscrypt.mod b/jetty-home/src/main/resources/modules/conscrypt.mod index a61af57bd748..d82148980521 100644 --- a/jetty-home/src/main/resources/modules/conscrypt.mod +++ b/jetty-home/src/main/resources/modules/conscrypt.mod @@ -27,5 +27,5 @@ Conscrypt is distributed under the Apache Licence 2.0 https://github.com/google/conscrypt/blob/master/LICENSE [ini] -conscrypt.version?=2.5.1 +conscrypt.version?=@conscrypt.version@ jetty.sslContext.provider?=Conscrypt diff --git a/jetty-home/src/main/resources/modules/hawtio.mod b/jetty-home/src/main/resources/modules/hawtio.mod index 050c6265449a..b4dd2a8fcd02 100644 --- a/jetty-home/src/main/resources/modules/hawtio.mod +++ b/jetty-home/src/main/resources/modules/hawtio.mod @@ -27,7 +27,7 @@ http://github.com/hawtio/hawtio http://www.apache.org/licenses/LICENSE-2.0.html [ini] -hawtio.version?=2.13.5 +hawtio.version?=@hawtio.version@ [ini-template] ## Hawt.io configuration diff --git a/jetty-home/src/main/resources/modules/jamon.mod b/jetty-home/src/main/resources/modules/jamon.mod index d72e16191eef..109410a2e8bd 100644 --- a/jetty-home/src/main/resources/modules/jamon.mod +++ b/jetty-home/src/main/resources/modules/jamon.mod @@ -17,8 +17,8 @@ etc/jamon.xml [files] lib/jamon/ -maven://com.jamonapi/jamon/2.81|lib/jamon/jamon-2.81.jar -maven://com.jamonapi/jamon_war/2.81/war|lib/jamon/jamon.war +maven://com.jamonapi/jamon/${jamon.version}|lib/jamon/jamon-${jamon.version}.jar +maven://com.jamonapi/jamon_war/${jamon.version}/war|lib/jamon/jamon.war basehome:modules/jamon/jamon.xml|etc/jamon.xml [lib] @@ -29,6 +29,9 @@ JAMon is a source forge hosted project released under a BSD derived license. http://jamonapi.sourceforge.net http://jamonapi.sourceforge.net/JAMonLicense.html +[ini] +jamon.version?=@jamon.version@ + [ini-template] ## Jamon Configuration # jamon.summaryLabels=demo diff --git a/jetty-home/src/main/resources/modules/jolokia.mod b/jetty-home/src/main/resources/modules/jolokia.mod index aea83e486089..ee4875d5d241 100644 --- a/jetty-home/src/main/resources/modules/jolokia.mod +++ b/jetty-home/src/main/resources/modules/jolokia.mod @@ -15,9 +15,12 @@ jmx etc/jolokia.xml [files] -maven://org.jolokia/jolokia-war/1.3.3/war|lib/jolokia/jolokia.war +maven://org.jolokia/jolokia-war/${jolokia.version}/war|lib/jolokia/jolokia.war basehome:modules/jolokia/jolokia.xml|etc/jolokia.xml +[ini] +jolokia.version?=@jolokia.version@ + [license] Jolokia is released under the Apache License 2.0 http://www.jolokia.org diff --git a/jetty-home/src/main/resources/modules/logging-jul.mod b/jetty-home/src/main/resources/modules/logging-jul.mod index 7bdafbf740af..2097219c226b 100644 --- a/jetty-home/src/main/resources/modules/logging-jul.mod +++ b/jetty-home/src/main/resources/modules/logging-jul.mod @@ -26,7 +26,7 @@ lib/logging/slf4j-jdk14-${slf4j.version}.jar -Djava.util.logging.config.file=${jetty.base}/resources/java-util-logging.properties [ini] -slf4j.version?=2.0.0-alpha5 +slf4j.version?=@slf4j.version@ [license] SLF4J is distributed under the MIT License. diff --git a/jetty-home/src/main/resources/modules/logging-log4j1.mod b/jetty-home/src/main/resources/modules/logging-log4j1.mod index fec58dc54e39..b19a511afbc3 100644 --- a/jetty-home/src/main/resources/modules/logging-log4j1.mod +++ b/jetty-home/src/main/resources/modules/logging-log4j1.mod @@ -25,7 +25,7 @@ lib/logging/slf4j-log4j12-${slf4j.version}.jar lib/logging/log4j-${log4j.version}.jar [ini] -log4j.version?=1.2.17 +log4j.version?=@log4j.version@ jetty.webapp.addServerClasses+=,org.apache.log4j. diff --git a/jetty-home/src/main/resources/modules/logging-log4j2.mod b/jetty-home/src/main/resources/modules/logging-log4j2.mod index 88ef9dc8b5ca..b75067bda21e 100644 --- a/jetty-home/src/main/resources/modules/logging-log4j2.mod +++ b/jetty-home/src/main/resources/modules/logging-log4j2.mod @@ -27,7 +27,7 @@ lib/logging/log4j-api-${log4j.version}.jar lib/logging/log4j-core-${log4j.version}.jar [ini] -log4j.version?=2.14.0 +log4j.version?=@log4j2.version@ jetty.webapp.addServerClasses+=,org.apache.logging.log4j. [license] diff --git a/jetty-home/src/main/resources/modules/logging-logback.mod b/jetty-home/src/main/resources/modules/logging-logback.mod index ea10e350d84f..ffba31c4c0b2 100644 --- a/jetty-home/src/main/resources/modules/logging-logback.mod +++ b/jetty-home/src/main/resources/modules/logging-logback.mod @@ -24,7 +24,7 @@ lib/logging/logback-classic-${logback.version}.jar lib/logging/logback-core-${logback.version}.jar [ini] -logback.version?=1.3.0-alpha9 +logback.version?=@logback.version@ jetty.webapp.addServerClasses+=,ch.qos.logback. [license] diff --git a/jetty-home/src/main/resources/modules/logging/slf4j.mod b/jetty-home/src/main/resources/modules/logging/slf4j.mod index 9eb3eeeba47c..861dd9e3b13e 100644 --- a/jetty-home/src/main/resources/modules/logging/slf4j.mod +++ b/jetty-home/src/main/resources/modules/logging/slf4j.mod @@ -15,5 +15,5 @@ slf4j lib/logging/slf4j-api-${slf4j.version}.jar [ini] -slf4j.version?=2.0.0-alpha5 +slf4j.version?=@slf4j.version@ jetty.webapp.addServerClasses+=,org.slf4j. diff --git a/jetty-infinispan/infinispan-common/src/main/config/modules/sessions/infinispan/infinispan-common.mod b/jetty-infinispan/infinispan-common/src/main/config/modules/sessions/infinispan/infinispan-common.mod index 02a77867610a..861c1ee2f22d 100644 --- a/jetty-infinispan/infinispan-common/src/main/config/modules/sessions/infinispan/infinispan-common.mod +++ b/jetty-infinispan/infinispan-common/src/main/config/modules/sessions/infinispan/infinispan-common.mod @@ -13,7 +13,7 @@ lib/infinispan-common-${jetty.version}.jar lib/infinispan/*.jar [ini] -infinispan.version?=9.4.8.Final +infinispan.version?=@infinispan.version@ [license] Infinispan is an open source project hosted on Github and released under the Apache 2.0 license. diff --git a/jetty-infinispan/infinispan-embedded-query/pom.xml b/jetty-infinispan/infinispan-embedded-query/pom.xml index 9ed4d852e390..7dfb812127b9 100644 --- a/jetty-infinispan/infinispan-embedded-query/pom.xml +++ b/jetty-infinispan/infinispan-embedded-query/pom.xml @@ -60,7 +60,7 @@ - + @@ -68,23 +68,6 @@ - - org.apache.maven.plugins - maven-assembly-plugin - - - package - - single - - - - src/main/assembly/config.xml - - - - - diff --git a/jetty-infinispan/infinispan-embedded-query/src/main/assembly/config.xml b/jetty-infinispan/infinispan-embedded-query/src/main/assembly/config.xml index d9db9a74ef21..499e2b0f61f9 100644 --- a/jetty-infinispan/infinispan-embedded-query/src/main/assembly/config.xml +++ b/jetty-infinispan/infinispan-embedded-query/src/main/assembly/config.xml @@ -7,7 +7,7 @@ - src/main/config-template + target/jetty-config-files ** diff --git a/jetty-infinispan/infinispan-embedded/src/main/config-templates/modules/session-store-infinispan-embedded.mod b/jetty-infinispan/infinispan-embedded/src/main/config-templates/modules/session-store-infinispan-embedded.mod index 8466ac5f2002..5100f968ebb6 100644 --- a/jetty-infinispan/infinispan-embedded/src/main/config-templates/modules/session-store-infinispan-embedded.mod +++ b/jetty-infinispan/infinispan-embedded/src/main/config-templates/modules/session-store-infinispan-embedded.mod @@ -16,7 +16,7 @@ sessions/infinispan/embedded/infinispan-embedded-libs basehome:modules/sessions/infinispan/embedded/infinispan.xml|etc/infinispan.xml [ini] -infinispan.version?=9.4.8.Final +infinispan.version?=@infinispan.version@ [ini-template] #jetty.session.infinispan.idleTimeout.seconds=0 diff --git a/jetty-infinispan/infinispan-remote-query/pom.xml b/jetty-infinispan/infinispan-remote-query/pom.xml index f112ee9e748b..954dd0e8a3e4 100644 --- a/jetty-infinispan/infinispan-remote-query/pom.xml +++ b/jetty-infinispan/infinispan-remote-query/pom.xml @@ -61,7 +61,7 @@ - + @@ -69,23 +69,6 @@ - - org.apache.maven.plugins - maven-assembly-plugin - - - package - - single - - - - src/main/assembly/config.xml - - - - - org.apache.maven.plugins maven-surefire-plugin diff --git a/jetty-infinispan/infinispan-remote-query/src/main/assembly/config.xml b/jetty-infinispan/infinispan-remote-query/src/main/assembly/config.xml index 270dcfad3825..fd4d89a9b6be 100644 --- a/jetty-infinispan/infinispan-remote-query/src/main/assembly/config.xml +++ b/jetty-infinispan/infinispan-remote-query/src/main/assembly/config.xml @@ -7,7 +7,7 @@ - src/main/config-template + target/jetty-config-files ** diff --git a/jetty-infinispan/infinispan-remote/pom.xml b/jetty-infinispan/infinispan-remote/pom.xml index 4e471c141825..852acc8f4179 100644 --- a/jetty-infinispan/infinispan-remote/pom.xml +++ b/jetty-infinispan/infinispan-remote/pom.xml @@ -62,7 +62,7 @@ - + @@ -70,24 +70,6 @@ - - - org.apache.maven.plugins - maven-assembly-plugin - - - package - - single - - - - src/main/assembly/config.xml - - - - - diff --git a/jetty-infinispan/infinispan-remote/src/main/assembly/config.xml b/jetty-infinispan/infinispan-remote/src/main/assembly/config.xml index 802f815d6aa5..a678d79f018b 100644 --- a/jetty-infinispan/infinispan-remote/src/main/assembly/config.xml +++ b/jetty-infinispan/infinispan-remote/src/main/assembly/config.xml @@ -7,7 +7,7 @@ - src/main/config-template + target/jetty-config-files ** diff --git a/jetty-infinispan/infinispan-remote/src/main/config-template/modules/session-store-infinispan-remote.mod b/jetty-infinispan/infinispan-remote/src/main/config-template/modules/session-store-infinispan-remote.mod index cfa1a0354951..26472c840e63 100644 --- a/jetty-infinispan/infinispan-remote/src/main/config-template/modules/session-store-infinispan-remote.mod +++ b/jetty-infinispan/infinispan-remote/src/main/config-template/modules/session-store-infinispan-remote.mod @@ -16,7 +16,7 @@ sessions/infinispan/remote/infinispan-remote-libs basehome:modules/sessions/infinispan/remote/resources/hotrod-client.properties|resources/hotrod-client.properties [ini] -infinispan.version?=9.4.8.Final +infinispan.version?=@infinispan.version@ [license] diff --git a/jetty-unixsocket/jetty-unixsocket-server/pom.xml b/jetty-unixsocket/jetty-unixsocket-server/pom.xml index 10953befda1c..d66a096e389e 100644 --- a/jetty-unixsocket/jetty-unixsocket-server/pom.xml +++ b/jetty-unixsocket/jetty-unixsocket-server/pom.xml @@ -76,32 +76,15 @@ - + - + - - org.apache.maven.plugins - maven-assembly-plugin - - - package - - single - - - - src/main/assembly/config.xml - - - - - diff --git a/jetty-unixsocket/jetty-unixsocket-server/src/main/assembly/config.xml b/jetty-unixsocket/jetty-unixsocket-server/src/main/assembly/config.xml index 3c97242ba281..f4dd8865b05b 100644 --- a/jetty-unixsocket/jetty-unixsocket-server/src/main/assembly/config.xml +++ b/jetty-unixsocket/jetty-unixsocket-server/src/main/assembly/config.xml @@ -7,7 +7,7 @@ - src/main/config-template + ${project.build.directory}/jetty-config-files ** @@ -18,7 +18,7 @@ - target + ${project.build.directory} modules unixsocket.mod diff --git a/pom.xml b/pom.xml index 6098b4d03071..1ba6085e4b74 100644 --- a/pom.xml +++ b/pom.xml @@ -21,6 +21,7 @@ 1.5 9.0 2.0.0-alpha5 + 1.2.17 2.14.0 1.3.0-alpha9 3.4.2 @@ -32,6 +33,9 @@ 4.3.4.Final 2.8.8 1.40.1 + 2.13.5 + 2.81 + 1.3.3 2.9.0 2.0.10 4.2.2 @@ -484,7 +488,7 @@ org.eclipse.jetty.toolchain jetty-assembly-descriptors - 1.0 + 1.1-SNAPSHOT @@ -1250,6 +1254,7 @@ jetty-perf-helper ${jetty.perf-helper.version} + org.slf4j jcl104-over-slf4j @@ -1276,11 +1281,26 @@ ${slf4j.version} test + + log4j + log4j + ${log4j.version} + + + org.apache.logging.log4j + log4j-api + ${log4j2.version} + org.jboss.logging jboss-logging ${jboss.logging.version} + + ch.qos.logback + logback-core + ${logback.version} + org.asciidoctor asciidoctor-maven-plugin @@ -1342,6 +1362,42 @@ commons-lang3 3.12.0 + + + io.hawt + hawtio-default + ${hawtio.version} + war + + + com.jamonapi + jamon + ${jamon.version} + + + javax.servlet + servlet-api + + + + + com.jamonapi + jamon_war + ${jamon.version} + war + + + javax.servlet + servlet-api + + + + + org.jolokia + jolokia-war + ${jolokia.version} + war + @@ -1434,6 +1490,36 @@ + + org.apache.maven.plugins + maven-resources-plugin + + + copy-resources + process-resources + + copy-resources + + + UTF-8 + false + + @ + + ${project.build.directory}/jetty-config-files + + + src/main/config + true + + **/*.p12 + + + + + + + org.apache.maven.plugins maven-assembly-plugin @@ -1455,6 +1541,65 @@ + + config-template + + + src/main/config-template + + + + + + org.apache.maven.plugins + maven-resources-plugin + + + copy-resources + process-resources + + copy-resources + + + UTF-8 + false + + @ + + ${project.build.directory}/jetty-config-files + + + src/main/config-template + true + + **/*.p12 + + + + + + + + + org.apache.maven.plugins + maven-assembly-plugin + + + package + + single + + + + src/main/assembly/config.xml + + + + + + + + eclipse-release