diff --git a/jetty-websocket/websocket-javax-client/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketClientShutdown.java b/jetty-websocket/websocket-javax-client/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketShutdownContainer.java similarity index 91% rename from jetty-websocket/websocket-javax-client/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketClientShutdown.java rename to jetty-websocket/websocket-javax-client/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketShutdownContainer.java index 3d189cb70efb..5a49e05137b2 100644 --- a/jetty-websocket/websocket-javax-client/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketClientShutdown.java +++ b/jetty-websocket/websocket-javax-client/src/main/java/org/eclipse/jetty/websocket/javax/client/JavaxWebSocketShutdownContainer.java @@ -26,9 +26,9 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class JavaxWebSocketClientShutdown extends ContainerLifeCycle implements ServletContainerInitializer, ServletContextListener +public class JavaxWebSocketShutdownContainer extends ContainerLifeCycle implements ServletContainerInitializer, ServletContextListener { - private static final Logger LOG = LoggerFactory.getLogger(JavaxWebSocketClientShutdown.class); + private static final Logger LOG = LoggerFactory.getLogger(JavaxWebSocketShutdownContainer.class); @Override public void onStartup(Set> c, ServletContext ctx) throws ServletException diff --git a/jetty-websocket/websocket-javax-client/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer b/jetty-websocket/websocket-javax-client/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer index b9a2f2d58b99..59e5f4b40551 100644 --- a/jetty-websocket/websocket-javax-client/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer +++ b/jetty-websocket/websocket-javax-client/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer @@ -1 +1 @@ -org.eclipse.jetty.websocket.javax.client.JavaxWebSocketClientShutdown \ No newline at end of file +org.eclipse.jetty.websocket.javax.client.JavaxWebSocketShutdownContainer \ No newline at end of file diff --git a/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/JavaxClientShutdownWithServerTest.java b/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/JavaxClientShutdownWithServerTest.java index f3b0eaae79f2..6f7959d1b467 100644 --- a/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/JavaxClientShutdownWithServerTest.java +++ b/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/JavaxClientShutdownWithServerTest.java @@ -13,10 +13,8 @@ package org.eclipse.jetty.websocket.javax.tests; -import java.io.IOException; import java.net.URI; import java.util.Collection; -import javax.servlet.ServletException; import javax.servlet.http.HttpServlet; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -32,7 +30,7 @@ import org.eclipse.jetty.servlet.ServletHolder; import org.eclipse.jetty.util.component.ContainerLifeCycle; import org.eclipse.jetty.util.component.LifeCycle; -import org.eclipse.jetty.websocket.javax.client.JavaxWebSocketClientShutdown; +import org.eclipse.jetty.websocket.javax.client.JavaxWebSocketShutdownContainer; import org.eclipse.jetty.websocket.javax.client.internal.JavaxWebSocketClientContainer; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; @@ -53,11 +51,10 @@ public class JavaxClientShutdownWithServerTest private volatile WebSocketContainer container; private ContainerLifeCycle shutdownContainer; - public class ContextHandlerShutdownServlet extends HttpServlet { @Override - protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException + protected void doGet(HttpServletRequest req, HttpServletResponse resp) { container = ContainerProvider.getWebSocketContainer(); } @@ -66,7 +63,7 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws Se public class ServletContainerInitializerShutdownServlet extends HttpServlet { @Override - protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException + protected void doGet(HttpServletRequest req, HttpServletResponse resp) { JavaxWebSocketClientContainer clientContainer = new JavaxWebSocketClientContainer(); clientContainer.allowShutdownWithContextHandler(false); @@ -84,12 +81,12 @@ public void before() throws Exception contextHandler = new ServletContextHandler(); contextHandler.setContextPath("/"); - contextHandler.addServlet(new ServletHolder(new ContextHandlerShutdownServlet()), "/contextHandlerShutdown"); - contextHandler.addServlet(new ServletHolder(new ServletContainerInitializerShutdownServlet()), "/servletContainerInitializerShutdown"); + contextHandler.addServlet(new ServletHolder(new ContextHandlerShutdownServlet()), "/contextHandler"); + contextHandler.addServlet(new ServletHolder(new ServletContainerInitializerShutdownServlet()), "/shutdownContainer"); server.setHandler(contextHandler); // Because we are using embedded we must manually add the Javax WS Client Shutdown SCI. - JavaxWebSocketClientShutdown javaxWebSocketClientShutdown = new JavaxWebSocketClientShutdown(); + JavaxWebSocketShutdownContainer javaxWebSocketClientShutdown = new JavaxWebSocketShutdownContainer(); shutdownContainer = javaxWebSocketClientShutdown; contextHandler.addServletContainerInitializer(javaxWebSocketClientShutdown); @@ -108,9 +105,9 @@ public void after() throws Exception } @Test - public void testWebSocketClientContainerInWebapp() throws Exception + public void testShutdownWithContextHandler() throws Exception { - ContentResponse response = httpClient.GET(serverUri.resolve("/contextHandlerShutdown")); + ContentResponse response = httpClient.GET(serverUri.resolve("/contextHandler")); assertThat(response.getStatus(), is(HttpStatus.OK_200)); assertNotNull(container); @@ -130,9 +127,9 @@ public void testWebSocketClientContainerInWebapp() throws Exception } @Test - public void testWebSocketClientContainerInWebapp2() throws Exception + public void testShutdownWithShutdownContainer() throws Exception { - ContentResponse response = httpClient.GET(serverUri.resolve("/servletContainerInitializerShutdown")); + ContentResponse response = httpClient.GET(serverUri.resolve("/shutdownContainer")); assertThat(response.getStatus(), is(HttpStatus.OK_200)); assertNotNull(container); diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java index d843b2c4edb3..7f225a812a4a 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java @@ -60,7 +60,7 @@ public static void configure(ServletContextHandler context, Configurator configu { if (!context.isStopped()) throw new IllegalStateException("configure should be called before starting"); - context.addServletContainerInitializer(new JettyWebSocketServletContainerInitializer()); + context.addServletContainerInitializer(new JettyWebSocketServletContainerInitializer(configurator)); } /**