diff --git a/jetty-gcloud/jetty-gcloud-session-manager/src/main/config-template/etc/sessions/gcloud/session-store.xml b/jetty-gcloud/jetty-gcloud-session-manager/src/main/config-template/etc/sessions/gcloud/session-store.xml index f04a90aee519..e40ae5b989a7 100644 --- a/jetty-gcloud/jetty-gcloud-session-manager/src/main/config-template/etc/sessions/gcloud/session-store.xml +++ b/jetty-gcloud/jetty-gcloud-session-manager/src/main/config-template/etc/sessions/gcloud/session-store.xml @@ -10,11 +10,11 @@ - + - - + + @@ -44,6 +44,9 @@ + + + diff --git a/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStore.java b/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStore.java index 541116e1c126..d120ff593ac1 100644 --- a/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStore.java +++ b/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStore.java @@ -55,6 +55,7 @@ public class GCloudSessionDataStore extends AbstractSessionDataStore public static final int DEFAULT_MAX_QUERY_RESULTS = 100; public static final int DEFAULT_MAX_RETRIES = 5; public static final int DEFAULT_BACKOFF_MS = 1000; + public static final String DEFAULT_NAMESPACE = ""; protected Datastore _datastore; protected KeyFactory _keyFactory; @@ -65,7 +66,7 @@ public class GCloudSessionDataStore extends AbstractSessionDataStore protected boolean _indexesPresent = false; protected EntityDataModel _model; protected boolean _modelProvided; - private String _namespace; + private String _namespace = DEFAULT_NAMESPACE; /** * EntityDataModel @@ -431,7 +432,7 @@ public void setNamespace(String namespace) _namespace = namespace; } - @ManagedAttribute(value = "gclound namespace", readonly = true) + @ManagedAttribute(value = "gcloud namespace", readonly = true) public String getNamespace() { return _namespace; diff --git a/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStoreFactory.java b/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStoreFactory.java index e35014296fd7..716e18f91028 100644 --- a/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStoreFactory.java +++ b/jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStoreFactory.java @@ -22,9 +22,9 @@ */ public class GCloudSessionDataStoreFactory extends AbstractSessionDataStoreFactory { - private String _namespace; - private int _maxRetries; - private int _backoffMs; + private String _namespace = GCloudSessionDataStore.DEFAULT_NAMESPACE; + private int _maxRetries = GCloudSessionDataStore.DEFAULT_MAX_RETRIES; + private int _backoffMs = GCloudSessionDataStore.DEFAULT_BACKOFF_MS; private GCloudSessionDataStore.EntityDataModel _model; public GCloudSessionDataStore.EntityDataModel getEntityDataModel() @@ -80,8 +80,9 @@ public SessionDataStore getSessionDataStore(SessionHandler handler) throws Excep ds.setBackoffMs(getBackoffMs()); ds.setMaxRetries(getMaxRetries()); ds.setGracePeriodSec(getGracePeriodSec()); - ds.setNamespace(_namespace); + ds.setNamespace(getNamespace()); ds.setSavePeriodSec(getSavePeriodSec()); + ds.setEntityDataModel(getEntityDataModel()); return ds; } } diff --git a/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/default.xml b/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/default.xml index 2da04b6b2c9d..07b47ee84b38 100644 --- a/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/default.xml +++ b/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/default.xml @@ -14,8 +14,8 @@ - - + + diff --git a/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/remote.xml b/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/remote.xml index 43675650e40a..377706a27c55 100644 --- a/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/remote.xml +++ b/jetty-hazelcast/src/main/config/etc/sessions/hazelcast/remote.xml @@ -10,21 +10,11 @@ - - - - - - - - - - - - - - - + + + + + diff --git a/jetty-http2/http2-server/src/main/config/etc/jetty-http2c.xml b/jetty-http2/http2-server/src/main/config/etc/jetty-http2c.xml index 3f77565aeecc..1cd68372f548 100644 --- a/jetty-http2/http2-server/src/main/config/etc/jetty-http2c.xml +++ b/jetty-http2/http2-server/src/main/config/etc/jetty-http2c.xml @@ -6,8 +6,8 @@ - - + + diff --git a/jetty-rewrite/src/main/config/etc/jetty-rewrite-customizer.xml b/jetty-rewrite/src/main/config/etc/jetty-rewrite-customizer.xml index a60f80555b78..6a9bf7999c28 100644 --- a/jetty-rewrite/src/main/config/etc/jetty-rewrite-customizer.xml +++ b/jetty-rewrite/src/main/config/etc/jetty-rewrite-customizer.xml @@ -9,7 +9,7 @@ - + diff --git a/jetty-rewrite/src/main/config/etc/jetty-rewrite.xml b/jetty-rewrite/src/main/config/etc/jetty-rewrite.xml index e123113c5c22..c78237e0c036 100644 --- a/jetty-rewrite/src/main/config/etc/jetty-rewrite.xml +++ b/jetty-rewrite/src/main/config/etc/jetty-rewrite.xml @@ -10,7 +10,7 @@ - + diff --git a/jetty-server/src/main/config/etc/jetty-gzip.xml b/jetty-server/src/main/config/etc/jetty-gzip.xml index 16f60c923549..96116cdc9df4 100644 --- a/jetty-server/src/main/config/etc/jetty-gzip.xml +++ b/jetty-server/src/main/config/etc/jetty-gzip.xml @@ -13,11 +13,7 @@ - - - - diff --git a/jetty-server/src/main/config/etc/jetty-threadlimit.xml b/jetty-server/src/main/config/etc/jetty-threadlimit.xml index d2300d5562c3..3d0c7e5626d6 100644 --- a/jetty-server/src/main/config/etc/jetty-threadlimit.xml +++ b/jetty-server/src/main/config/etc/jetty-threadlimit.xml @@ -10,7 +10,7 @@ - + diff --git a/jetty-server/src/main/config/etc/jetty.xml b/jetty-server/src/main/config/etc/jetty.xml index 7a3f85cf65bd..93fa0d250836 100644 --- a/jetty-server/src/main/config/etc/jetty.xml +++ b/jetty-server/src/main/config/etc/jetty.xml @@ -66,8 +66,8 @@ - - + + diff --git a/jetty-server/src/main/config/etc/sessions/jdbc/session-store.xml b/jetty-server/src/main/config/etc/sessions/jdbc/session-store.xml index 7c565b318ce5..963c5252b09a 100644 --- a/jetty-server/src/main/config/etc/sessions/jdbc/session-store.xml +++ b/jetty-server/src/main/config/etc/sessions/jdbc/session-store.xml @@ -8,8 +8,8 @@ - - + + diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java b/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java index d95a8406ce41..350d75d92705 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java @@ -78,7 +78,7 @@ public class Server extends HandlerWrapper implements Attributes private final ThreadPool _threadPool; private final List _connectors = new CopyOnWriteArrayList<>(); private SessionIdManager _sessionIdManager; - private boolean _stopAtShutdown; + private boolean _stopAtShutdown = true; private boolean _dumpAfterStart; private boolean _dumpBeforeStop; private ErrorHandler _errorHandler; diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStore.java b/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStore.java index 47d46564b819..49ee9690f160 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStore.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStore.java @@ -30,12 +30,15 @@ public abstract class AbstractSessionDataStore extends ContainerLifeCycle implements SessionDataStore { private static final Logger LOG = LoggerFactory.getLogger(AbstractSessionDataStore.class); + + public static final int DEFAULT_GRACE_PERIOD_SEC = 60 * 60; //default of 1hr + public static final int DEFAULT_SAVE_PERIOD_SEC = 0; protected SessionContext _context; //context associated with this session data store - protected int _gracePeriodSec = 60 * 60; //default of 1hr + protected int _gracePeriodSec = DEFAULT_GRACE_PERIOD_SEC; protected long _lastExpiryCheckTime = 0; //last time in ms that getExpired was called protected long _lastOrphanSweepTime = 0; //last time in ms that we deleted orphaned sessions - protected int _savePeriodSec = 0; //time in sec between saves + protected int _savePeriodSec = DEFAULT_SAVE_PERIOD_SEC; //time in sec between saves /** * Small utility class to allow us to diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStoreFactory.java b/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStoreFactory.java index 823502dc633b..d6b47dd328b0 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStoreFactory.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/session/AbstractSessionDataStoreFactory.java @@ -19,8 +19,8 @@ public abstract class AbstractSessionDataStoreFactory implements SessionDataStoreFactory { - int _gracePeriodSec; - int _savePeriodSec; + int _gracePeriodSec = AbstractSessionDataStore.DEFAULT_GRACE_PERIOD_SEC; + int _savePeriodSec = AbstractSessionDataStore.DEFAULT_SAVE_PERIOD_SEC; /** * @return the gracePeriodSec diff --git a/jetty-unixsocket/jetty-unixsocket-server/src/main/config-template/etc/jetty-unixsocket-http2c.xml b/jetty-unixsocket/jetty-unixsocket-server/src/main/config-template/etc/jetty-unixsocket-http2c.xml index 3871d02981a9..75cb2a487a29 100644 --- a/jetty-unixsocket/jetty-unixsocket-server/src/main/config-template/etc/jetty-unixsocket-http2c.xml +++ b/jetty-unixsocket/jetty-unixsocket-server/src/main/config-template/etc/jetty-unixsocket-http2c.xml @@ -6,8 +6,8 @@ - - + +