From 2cd5990095b93db2ff9c041c8f5991358c130754 Mon Sep 17 00:00:00 2001 From: Simone Bordet Date: Thu, 25 Mar 2021 11:32:51 +0100 Subject: [PATCH] Issue #6085 Fix duplicate valid session cookies to pick first valid. Cosmetic changes. Signed-off-by: Simone Bordet --- .../eclipse/jetty/server/session/SessionHandler.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/session/SessionHandler.java b/jetty-server/src/main/java/org/eclipse/jetty/server/session/SessionHandler.java index 8be2c5a49f64..63591ef1e73e 100644 --- a/jetty-server/src/main/java/org/eclipse/jetty/server/session/SessionHandler.java +++ b/jetty-server/src/main/java/org/eclipse/jetty/server/session/SessionHandler.java @@ -1674,8 +1674,7 @@ else if (!DispatcherType.REQUEST.equals(baseRequest.getDispatcherType())) if (s != null && isValid(s)) { //associate it with the request so its reference count is decremented as the - //session exits - //try this session id + //request exits requestedSessionId = id; session = s; baseRequest.enterSession(session); @@ -1713,8 +1712,11 @@ else if (!DispatcherType.REQUEST.equals(baseRequest.getDispatcherType())) throw new BadMessageException("Duplicate valid session cookies: " + requestedSessionId + " ," + id); } } - else if (LOG.isDebugEnabled()) - LOG.debug("Duplicate valid session cookie id: {}", id); + else + { + if (LOG.isDebugEnabled()) + LOG.debug("Duplicate valid session cookie id: {}", id); + } } } }