Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in the parser finally leading to Stack Overflow #47

Closed
kmnls opened this issue Aug 25, 2022 · 1 comment
Closed

Infinite loop in the parser finally leading to Stack Overflow #47

kmnls opened this issue Aug 25, 2022 · 1 comment

Comments

@kmnls
Copy link

kmnls commented Aug 25, 2022

Description:

Initializing JSONObject with a string consisting of any of opening brackets ('{', '[') and ending with a slash '/' will result in stack overflow.

Minimal reproducible example:

import org.codehaus.jettison.mapped.*;
import org.codehaus.jettison.json.JSONObject;

public class Test {
    public static void main(String[] args) throws Exception 
        JSONObject obj = new JSONObject("{/");
    }
}

Log:

Exception in thread "main" java.lang.StackOverflowError
at java.base/java.lang.String.charAt(String.java:693)
at org.codehaus.jettison.json.JSONTokener.next(JSONTokener.java:124)
at org.codehaus.jettison.json.JSONTokener.nextClean(JSONTokener.java:177)
at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:326)
at org.codehaus.jettison.json.JSONObject.(JSONObject.java:218)
at org.codehaus.jettison.json.JSONTokener.newJSONObject(JSONTokener.java:424)
at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:335)
at org.codehaus.jettison.json.JSONObject.(JSONObject.java:218)
at org.codehaus.jettison.json.JSONTokener.newJSONObject(JSONTokener.java:424)
at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:335)
at org.codehaus.jettison.json.JSONObject.(JSONObject.java:218)
at org.codehaus.jettison.json.JSONTokener.newJSONObject(JSONTokener.java:424)
at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:335)
at org.codehaus.jettison.json.JSONObject.(JSONObject.java:218)
at org.codehaus.jettison.json.JSONTokener.newJSONObject(JSONTokener.java:424)
at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:335)
at org.codehaus.jettison.json.JSONObject.(JSONObject.java:218)

@coheigea
Copy link
Contributor

Fixed in 1.5.1 by #48 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants