From 7c86a7db87156183efa9aee7fdd147d8fbc56a5a Mon Sep 17 00:00:00 2001 From: Mihail Bodrov Date: Wed, 8 May 2019 00:41:54 +0300 Subject: [PATCH 1/2] [jest-leak-detector] remove code repeat :art: --- packages/jest-leak-detector/package.json | 1 + packages/jest-leak-detector/src/index.ts | 7 ++----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/jest-leak-detector/package.json b/packages/jest-leak-detector/package.json index d427b56c73ee..e574057a8259 100644 --- a/packages/jest-leak-detector/package.json +++ b/packages/jest-leak-detector/package.json @@ -10,6 +10,7 @@ "main": "build/index.js", "types": "build/index.d.ts", "dependencies": { + "jest-get-type": "^24.8.0", "pretty-format": "^24.8.0" }, "devDependencies": { diff --git a/packages/jest-leak-detector/src/index.ts b/packages/jest-leak-detector/src/index.ts index 007b907fad6e..68cdd9a1770a 100644 --- a/packages/jest-leak-detector/src/index.ts +++ b/packages/jest-leak-detector/src/index.ts @@ -8,12 +8,13 @@ import v8 from 'v8'; import vm from 'vm'; import prettyFormat from 'pretty-format'; +import {isPrimitive} from 'jest-get-type'; export default class { private _isReferenceBeingHeld: boolean; constructor(value: unknown) { - if (this._isPrimitive(value)) { + if (isPrimitive(value)) { throw new TypeError( [ 'Primitives cannot leak memory.', @@ -63,8 +64,4 @@ export default class { v8.setFlagsFromString('--no-expose-gc'); } } - - private _isPrimitive(value: unknown): boolean { - return value !== Object(value); - } } From fef529e37e975ba1f5e7696921fb49e1c5badac4 Mon Sep 17 00:00:00 2001 From: Mihail Bodrov Date: Wed, 8 May 2019 00:48:37 +0300 Subject: [PATCH 2/2] Update change log :memo: --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b7fc6aa8f62c..00e413a7e791 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ ### Chore & Maintenance +- `[jest-leak-detector]` remove code repeat ([#8438](https://github.com/facebook/jest/pull/8438) + ### Performance ## 24.8.0