From 51c39298048f3fd45499844655b8edcd141a9940 Mon Sep 17 00:00:00 2001 From: victorphoenix3 Date: Tue, 6 Oct 2020 05:42:24 +0530 Subject: [PATCH] validate testURL as CLI option --- CHANGELOG.md | 1 + .../src/__tests__/validateCLIOptions.test.js | 13 +++++++++++++ packages/jest-validate/src/validateCLIOptions.ts | 1 + 3 files changed, 15 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e697b9155db..a1296b155310 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Fixes - `[jest-validate]` Show suggestion only when unrecognized cli param is longer than 1 character ([#10604](https://github.com/facebook/jest/pull/10604)) +- `[jest-validate]` Validate `testURL` as CLI option ([#10595](https://github.com/facebook/jest/pull/10595)) ### Chore & Maintenance diff --git a/packages/jest-validate/src/__tests__/validateCLIOptions.test.js b/packages/jest-validate/src/__tests__/validateCLIOptions.test.js index 05b06762b9d8..7b7ef1ff9fe6 100644 --- a/packages/jest-validate/src/__tests__/validateCLIOptions.test.js +++ b/packages/jest-validate/src/__tests__/validateCLIOptions.test.js @@ -19,6 +19,19 @@ test('validates yargs special options', () => { expect(validateCLIOptions(argv, options)).toBe(true); }); +test('validates testURL', () => { + const options = { + testURL: { + description: 'This option sets the URL for the jsdom environment.', + type: 'string', + }, + }; + const argv = { + testURL: 'http://localhost', + }; + expect(validateCLIOptions(argv, options)).toBe(true); +}); + test('fails for unknown option', () => { const options = ['$0', '_', 'help', 'h']; const argv = { diff --git a/packages/jest-validate/src/validateCLIOptions.ts b/packages/jest-validate/src/validateCLIOptions.ts index 875194ae798f..80627d12ff6e 100644 --- a/packages/jest-validate/src/validateCLIOptions.ts +++ b/packages/jest-validate/src/validateCLIOptions.ts @@ -79,6 +79,7 @@ export default function validateCLIOptions( const unrecognizedOptions = Object.keys(argv).filter( arg => !allowedOptions.has(camelcase(arg)) && + !allowedOptions.has(arg) && (!rawArgv.length || rawArgv.includes(arg)), [], );