From b915855f2437cde999e29f14fa33de228ac090c9 Mon Sep 17 00:00:00 2001 From: Josh Kelly Date: Sat, 1 Aug 2020 20:41:49 +0100 Subject: [PATCH 1/2] fix(worker): downgrade minimum required node version to 10.13 Signed-off-by: Josh Kelly --- CHANGELOG.md | 2 ++ packages/jest-worker/package.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2e87445cb0e3..3ba9036ea887 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ ### Fixes +- `[jest-worker]` Downgrade minimum node version to 10.13 ([#10352](https://github.com/facebook/jest/pull/10352)) + ### Chore & Maintenance ### Performance diff --git a/packages/jest-worker/package.json b/packages/jest-worker/package.json index 8bf1fc9079ea..0f7f9d5316ab 100644 --- a/packages/jest-worker/package.json +++ b/packages/jest-worker/package.json @@ -21,7 +21,7 @@ "worker-farm": "^1.6.0" }, "engines": { - "node": ">= 10.14.2" + "node": ">= 10.14.2 || >= 10.13.0" }, "publishConfig": { "access": "public" From 531154033698ac6ce38165974fd6b819be28e28b Mon Sep 17 00:00:00 2001 From: Josh Kelly Date: Sun, 2 Aug 2020 00:33:57 +0100 Subject: [PATCH 2/2] Amend `buildUtils` to add engine exception for `jest-worker` An exception needs to be added against the assertion of the node engine version for sub packages. jest-worker requires a lower version than root and the current assertion fails the build. Signed-off-by: Josh Kelly --- packages/jest-worker/package.json | 2 +- scripts/buildUtils.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/jest-worker/package.json b/packages/jest-worker/package.json index 0f7f9d5316ab..8e2d335c3433 100644 --- a/packages/jest-worker/package.json +++ b/packages/jest-worker/package.json @@ -21,7 +21,7 @@ "worker-farm": "^1.6.0" }, "engines": { - "node": ">= 10.14.2 || >= 10.13.0" + "node": ">= 10.13.0" }, "publishConfig": { "access": "public" diff --git a/scripts/buildUtils.js b/scripts/buildUtils.js index 90e9bb71bc4a..7430ce714933 100644 --- a/scripts/buildUtils.js +++ b/scripts/buildUtils.js @@ -34,7 +34,7 @@ module.exports.getPackages = function getPackages() { assert.equal( pkg.engines.node, - nodeEngineRequiremnt, + pkg.name === 'jest-worker' ? '>= 10.13.0' : nodeEngineRequiremnt, `Engine requirement in ${pkg.name} should match root`, ); });