Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser options breaks module resolution #7840

Closed
lhorie opened this issue Feb 8, 2019 · 2 comments 路 Fixed by #9511
Closed

browser options breaks module resolution #7840

lhorie opened this issue Feb 8, 2019 · 2 comments 路 Fixed by #9511

Comments

@lhorie
Copy link

lhorie commented Feb 8, 2019

馃悰 Bug Report

Setting browser: true in jest config causes modules to be run more than once

To Reproduce

git clone git@github.com:lhorie/jest-browser-bug.git
cd jest-browser-bug
yarn
yarn test

Expected behavior

Each module should only ever run once

Link to repl or repo (highly encouraged)

https://github.com/lhorie/jest-browser-bug

Run npx envinfo --preset jest

Paste the results here:

Environment:
  OS:  macOS 10.14.1
  Node:  8.12.0
  Yarn:  1.12.3
  npm:  6.4.1
  Watchman:  Not Found
  Xcode:  Xcode 10.1 Build version 10B61
  Android Studio:  Not Found
@lhorie
Copy link
Author

lhorie commented Feb 9, 2019

I isolated the issue to the node-browser-resolve package. This PR fixes it browserify/browser-resolve#92

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant