Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/Bug Report] Discourage/disable "./" as one of the "moduleDirectories" #10498

Closed
davidroeca opened this issue Sep 10, 2020 · 8 comments 路 May be fixed by #14913
Closed

[Feature/Bug Report] Discourage/disable "./" as one of the "moduleDirectories" #10498

davidroeca opened this issue Sep 10, 2020 · 8 comments 路 May be fixed by #14913
Labels
Bug Report Needs Triage Stale

Comments

@davidroeca
Copy link

davidroeca commented Sep 10, 2020 •
edited

馃悰 Bug Report

This is a bug report pertaining to the use of "./" as one of the moduleDirectories. In particular, I was using a scoped package that had the same subdirectory name as a non-scoped package (e.g. @my-scope/my-package relies on my-package as an external/peer dependency). This prevented @my-scope/my-package from having access to my-package.

To Reproduce

See this repo

Expected behavior

Ideally, this behavior is not allowed. We should instead encourage people to use moduleNameMapper.

Link to repl or repo (highly encouraged)

Again see https://github.com/davidroeca/jest-shadowing-issue

envinfo

  System:
    OS: Linux 5.4 Linux Mint 20 (Ulyana)
    CPU: (8) x64 Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
  Binaries:
    Node: 14.9.0 - ~/.asdf/installs/nodejs/14.9.0/bin/node
    Yarn: 1.22.4 - ~/.asdf/shims/yarn
    npm: 6.14.8 - ~/.asdf/installs/nodejs/14.9.0/bin/npm
  npmPackages:
    jest: ^26.4.2 => 26.4.2
@davidroeca davidroeca changed the title [Feature] Discourage/disable "./" as one of the "moduleDirectories" [Feature/Bug Report] Discourage/disable "./" as one of the "moduleDirectories" Sep 10, 2020
@davidroeca
Copy link
Author

Apologies, hit enter too soon. Edited the issue with the correct info.

@geritol geritol mentioned this issue Apr 4, 2021
Closed
2 tasks
@geritol
Copy link

geritol commented Apr 4, 2021

I have also run into this issue (@emotion/react having react as a dependency).
@davidroeca I think the Needs Repro label can be removed as there seems to be a reproduction.

@geritol
Copy link

geritol commented Apr 4, 2021 •
edited

for the record:

// jest.config.js
module.exports = {
  // ...
-  moduleDirectories: ["node_modules", "."]
+  moduleDirectories: ["node_modules", "<rootDir>"],
};

solves the issue

@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 17, 2023
@davidroeca
Copy link
Author

I see no mentions/cautions here. I believe it is still at the very least worth discouraging somewhere in the docs.

@github-actions github-actions bot removed the Stale label Feb 17, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 17, 2024
davidroeca added a commit to davidroeca/jest that referenced this issue Feb 21, 2024
@davidroeca
add caution note to '.' usage in moduleDirectories
7be4e56 
resolves jestjs#10498
@davidroeca davidroeca mentioned this issue Feb 21, 2024
Open
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Report Needs Triage Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add caution note to '.' usage in moduleDirectories davidroeca/jest
3 participants
@SimenB @geritol @davidroeca