Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change required node version for jest-worker to 10.13 #10142

Closed
alexander-akait opened this issue Jun 8, 2020 · 4 comments 路 Fixed by #10352
Closed

Change required node version for jest-worker to 10.13 #10142

alexander-akait opened this issue Jun 8, 2020 · 4 comments 路 Fixed by #10352
Labels
good first issue Help Wanted 馃殌 Feature Request

Comments

@alexander-akait
Copy link
Contributor

馃殌 Feature Proposal

Change required node version for jest-worker to 10.13. https://github.com/facebook/jest/blob/master/packages/jest-worker/package.json (es exception)

Motivation

Ref: webpack-contrib/terser-webpack-plugin#248

Example

Just set ">= 10.13.0"

Pitch

does not matter
@alexander-akait alexander-akait mentioned this issue Jun 8, 2020
Closed
@matthewbub
Copy link

I'll take this one!

@matthewbub matthewbub mentioned this issue Jun 8, 2020
Closed
@nonewcode nonewcode mentioned this issue Aug 1, 2020
Merged
@nonewcode
Copy link
Contributor

Hope you don't mind @hi-matbub but seen this was slightly stale and have opened a PR to get it closed: #10352

@nonewcode
Copy link
Contributor

I've moved the PR to be a draft as the engine of the sub packages needs to match the root version. May be a case that we cannot fulfill this change? @jeysal thoughts?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Help Wanted 馃殌 Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(worker): downgrade minimum required node version to 10.13
4 participants
@alexander-akait @nonewcode @jeysal @matthewbub