Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--notify does not seem to be working anymore #10114

Closed
JoshuaVSherman opened this issue Jun 1, 2020 · 2 comments
Closed

--notify does not seem to be working anymore #10114

JoshuaVSherman opened this issue Jun 1, 2020 · 2 comments

Comments

@JoshuaVSherman
Copy link

🐛 Bug Report

--notify and/or adding notify: true to config does nothing

To Reproduce

Steps to reproduce the behavior:
do the above, I also tried with latest version of jest and an older version of jest so possibly it is the underlying node-notifier package that is no longer working

Expected behavior

pop up saying how many tests passed

Link to repl or repo (highly encouraged)

https://github.com/WebJamApps/JaMmusic

envinfo

I am on Ubuntu 18.04 LTS and have confirmed that I have libnotify-bin

System:
OS: Linux 5.3 Ubuntu 18.04.4 LTS (Bionic Beaver)
CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
Binaries:
Node: 14.3.0 - ~/.nvm/versions/node/v14.3.0/bin/node
Yarn: 1.22.4 - /usr/bin/yarn
npm: 6.14.5 - ~/.nvm/versions/node/v14.3.0/bin/npm
npmPackages:
jest: latest => 26.0.1

Note from coworker who just debugged it:

Oh wait, no, the actual bug is that it should be timeout: 0
[2:09 PM]
GNOME just ignores the timeout flag and handles all notifications the same way but notify-send itself or GNOME reject the one from jest because false isn't a valid value
[2:13 PM]
Yeah if jest was actually using a callback for node-notifier they'd be getting an error response telling them Cannot parse integer value “false” for --expire-time

@JoshuaVSherman
Copy link
Author

closing as found duplicate here, #9701

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant