From fe5b29aa8718d222a17574dc5d033e84d897ea9f Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 2 Aug 2020 22:22:46 +1200 Subject: [PATCH] chore: remove unused errors in `catch`s, and `reject` parameters (#10354) --- e2e/__tests__/snapshot.test.ts | 2 +- .../__tests__/matchers-toEqual.property.test.ts | 2 +- .../matchers-toStrictEqual.property.test.ts | 4 ++-- .../expect/src/__tests__/spyMatchers.test.ts | 16 ++++++++-------- packages/expect/src/index.ts | 2 +- packages/jest-changed-files/src/git.ts | 2 +- packages/jest-changed-files/src/hg.ts | 2 +- packages/jest-cli/src/cli/index.ts | 2 +- packages/jest-cli/src/init/index.ts | 2 +- packages/jest-config/src/__mocks__/read-pkg.js | 2 +- packages/jest-config/src/index.ts | 2 +- packages/jest-config/src/normalize.ts | 8 ++++---- packages/jest-config/src/utils.ts | 4 ++-- packages/jest-config/src/validatePattern.ts | 2 +- packages/jest-core/src/TestNamePatternPrompt.ts | 2 +- packages/jest-core/src/TestPathPatternPrompt.ts | 2 +- packages/jest-core/src/cli/index.ts | 2 +- packages/jest-diff/src/index.ts | 2 +- .../jest-haste-map/src/__tests__/index.test.js | 2 +- packages/jest-haste-map/src/index.ts | 4 ++-- .../jest-haste-map/src/lib/FSEventsWatcher.ts | 2 +- .../jest-haste-map/src/lib/isRegExpSupported.ts | 2 +- .../jest-jasmine2/src/__tests__/pTimeout.test.ts | 2 +- packages/jest-jasmine2/src/jasmine/Suite.ts | 2 +- .../jest-jasmine2/src/jasmine/spyRegistry.ts | 4 ++-- packages/jest-matcher-utils/src/index.ts | 2 +- packages/jest-message-util/src/index.ts | 4 ++-- packages/jest-mock/src/__tests__/index.test.ts | 2 +- packages/jest-reporters/src/coverage_reporter.ts | 2 +- packages/jest-resolve/src/nodeModulesPaths.ts | 2 +- packages/jest-runner/src/runTest.ts | 2 +- .../test_root/__mocks__/ManuallyMocked.js | 2 +- .../jest-serializer/src/__tests__/index.test.ts | 2 +- .../src/__tests__/mock_serializer.test.ts | 2 +- packages/jest-snapshot/src/utils.ts | 4 ++-- packages/jest-source-map/src/getCallsite.ts | 2 +- packages/jest-test-sequencer/src/index.ts | 2 +- packages/jest-transform/src/ScriptTransformer.ts | 4 ++-- .../src/lib/formatTestNameByPattern.ts | 2 +- .../src/__performance_tests__/test.js | 4 ++-- .../src/workers/__tests__/processChild.test.js | 2 +- .../src/workers/__tests__/threadChild.test.js | 2 +- .../jest-worker/src/workers/messageParent.ts | 2 +- scripts/watch.js | 6 +++--- 44 files changed, 64 insertions(+), 64 deletions(-) diff --git a/e2e/__tests__/snapshot.test.ts b/e2e/__tests__/snapshot.test.ts index 5396a73b7f95..b4c41db5d04e 100644 --- a/e2e/__tests__/snapshot.test.ts +++ b/e2e/__tests__/snapshot.test.ts @@ -59,7 +59,7 @@ const initialTestData = fs.readFileSync(snapshotEscapeTestFile, 'utf8'); const fileExists = (filePath: string) => { try { return fs.statSync(filePath).isFile(); - } catch (e) {} + } catch {} return false; }; const getSnapshotOfCopy = () => { diff --git a/packages/expect/src/__tests__/matchers-toEqual.property.test.ts b/packages/expect/src/__tests__/matchers-toEqual.property.test.ts index d1efc6b31bb8..71769f123876 100644 --- a/packages/expect/src/__tests__/matchers-toEqual.property.test.ts +++ b/packages/expect/src/__tests__/matchers-toEqual.property.test.ts @@ -29,7 +29,7 @@ describe('toEqual', () => { try { expect(a).toEqual(b); return true; - } catch (err) { + } catch { return false; } }; diff --git a/packages/expect/src/__tests__/matchers-toStrictEqual.property.test.ts b/packages/expect/src/__tests__/matchers-toStrictEqual.property.test.ts index a12f5a39a857..547478a3e542 100644 --- a/packages/expect/src/__tests__/matchers-toStrictEqual.property.test.ts +++ b/packages/expect/src/__tests__/matchers-toStrictEqual.property.test.ts @@ -20,7 +20,7 @@ describe('toStrictEqual', () => { try { expect(a).toStrictEqual(b); return true; - } catch (err) { + } catch { return false; } }; @@ -28,7 +28,7 @@ describe('toStrictEqual', () => { try { assert.deepStrictEqual(a, b); return true; - } catch (err) { + } catch { return false; } }; diff --git a/packages/expect/src/__tests__/spyMatchers.test.ts b/packages/expect/src/__tests__/spyMatchers.test.ts index e819b2efcfb9..cebf5682e198 100644 --- a/packages/expect/src/__tests__/spyMatchers.test.ts +++ b/packages/expect/src/__tests__/spyMatchers.test.ts @@ -453,7 +453,7 @@ const createSpy = (fn: jest.Mock) => { try { fn(true); - } catch (error) { + } catch { // ignore error } @@ -479,13 +479,13 @@ const createSpy = (fn: jest.Mock) => { try { fn(); - } catch (error) { + } catch { // ignore error } try { fn(); - } catch (error) { + } catch { // ignore error } @@ -501,7 +501,7 @@ const createSpy = (fn: jest.Mock) => { try { fn(); - } catch (error) { + } catch { // ignore error } @@ -652,7 +652,7 @@ const createSpy = (fn: jest.Mock) => { try { fn(true); - } catch (error) { + } catch { // ignore error } @@ -679,7 +679,7 @@ const createSpy = (fn: jest.Mock) => { try { fn(true); - } catch (error) { + } catch { // ignore error } @@ -886,7 +886,7 @@ const createSpy = (fn: jest.Mock) => { try { fn(); - } catch (error) { + } catch { // ignore error } @@ -908,7 +908,7 @@ const createSpy = (fn: jest.Mock) => { try { fn(); - } catch (error) { + } catch { // ignore error } diff --git a/packages/expect/src/index.ts b/packages/expect/src/index.ts index c715cd97354d..98719325cbde 100644 --- a/packages/expect/src/index.ts +++ b/packages/expect/src/index.ts @@ -338,7 +338,7 @@ const makeThrowingMatcher = ( return asyncResult .then(aResult => processResult(aResult, asyncError)) - .catch(error => handleError(error)); + .catch(handleError); } else { const syncResult = potentialResult as SyncExpectationResult; diff --git a/packages/jest-changed-files/src/git.ts b/packages/jest-changed-files/src/git.ts index da1329a77bbb..f5cae575fa9b 100644 --- a/packages/jest-changed-files/src/git.ts +++ b/packages/jest-changed-files/src/git.ts @@ -94,7 +94,7 @@ const adapter: SCMAdapter = { const result = await execa('git', options, {cwd}); return path.resolve(cwd, result.stdout); - } catch (e) { + } catch { return null; } }, diff --git a/packages/jest-changed-files/src/hg.ts b/packages/jest-changed-files/src/hg.ts index a1f41978b93a..3840bc983554 100644 --- a/packages/jest-changed-files/src/hg.ts +++ b/packages/jest-changed-files/src/hg.ts @@ -51,7 +51,7 @@ const adapter: SCMAdapter = { const result = await execa('hg', ['root'], {cwd, env}); return result.stdout; - } catch (e) { + } catch { return null; } }, diff --git a/packages/jest-cli/src/cli/index.ts b/packages/jest-cli/src/cli/index.ts index 41d3302c7e0c..6e0d853aa8c3 100644 --- a/packages/jest-cli/src/cli/index.ts +++ b/packages/jest-cli/src/cli/index.ts @@ -97,7 +97,7 @@ const getProjectListFromCLIArgs = ( if (!projects.length && process.platform === 'win32') { try { projects.push(tryRealpath(process.cwd())); - } catch (err) { + } catch { // do nothing, just catch error // process.binding('fs').realpath can throw, e.g. on mapped drives } diff --git a/packages/jest-cli/src/init/index.ts b/packages/jest-cli/src/init/index.ts index 707b41df12bc..82b0fceffa4b 100644 --- a/packages/jest-cli/src/init/index.ts +++ b/packages/jest-cli/src/init/index.ts @@ -53,7 +53,7 @@ export default async ( projectPackageJson = JSON.parse( fs.readFileSync(projectPackageJsonPath, 'utf-8'), ); - } catch (error) { + } catch { throw new MalformedPackageJsonError(projectPackageJsonPath); } diff --git a/packages/jest-config/src/__mocks__/read-pkg.js b/packages/jest-config/src/__mocks__/read-pkg.js index 0c6f426d5407..7d0c3641ce0f 100644 --- a/packages/jest-config/src/__mocks__/read-pkg.js +++ b/packages/jest-config/src/__mocks__/read-pkg.js @@ -20,7 +20,7 @@ function readPkg(file) { try { const json = JSON.parse(mockFile); return Promise.resolve(json); - } catch (err) { + } catch { return Promise.reject(`${file} is not valid JSON.`); } } diff --git a/packages/jest-config/src/index.ts b/packages/jest-config/src/index.ts index 8588b49118a8..abbbdeea68fa 100644 --- a/packages/jest-config/src/index.ts +++ b/packages/jest-config/src/index.ts @@ -64,7 +64,7 @@ export async function readConfig( let config; try { config = JSON.parse(argv.config); - } catch (e) { + } catch { throw new Error( 'There was an error while parsing the `--config` argument as a JSON string.', ); diff --git a/packages/jest-config/src/normalize.ts b/packages/jest-config/src/normalize.ts index ecd851488142..db26b8740ab2 100644 --- a/packages/jest-config/src/normalize.ts +++ b/packages/jest-config/src/normalize.ts @@ -138,7 +138,7 @@ const setupPreset = ( if (presetModule) { delete require.cache[require.resolve(presetModule)]; } - } catch (e) {} + } catch {} // @ts-expect-error: `presetModule` can be null? preset = require(presetModule); @@ -278,7 +278,7 @@ const normalizeCollectCoverageFrom = ( if (!Array.isArray(initialCollectCoverageFrom)) { try { value = JSON.parse(initialCollectCoverageFrom); - } catch (e) {} + } catch {} if (options[key] && !Array.isArray(value)) { value = [initialCollectCoverageFrom]; @@ -391,7 +391,7 @@ const normalizeRootDir = ( try { // try to resolve windows short paths, ignoring errors (permission errors, mostly) options.rootDir = tryRealpath(options.rootDir); - } catch (e) { + } catch { // ignored } @@ -956,7 +956,7 @@ export default function normalize( try { // try to resolve windows short paths, ignoring errors (permission errors, mostly) newOptions.cwd = tryRealpath(process.cwd()); - } catch (e) { + } catch { // ignored } diff --git a/packages/jest-config/src/utils.ts b/packages/jest-config/src/utils.ts index ea093ff50747..baa834fffcf9 100644 --- a/packages/jest-config/src/utils.ts +++ b/packages/jest-config/src/utils.ts @@ -144,7 +144,7 @@ export const resolveWithPrefix = ( try { return require.resolve(`${prefix}${fileName}`); - } catch (e) {} + } catch {} module = Resolver.findNodeModule(fileName, { basedir: rootDir, @@ -156,7 +156,7 @@ export const resolveWithPrefix = ( try { return require.resolve(fileName); - } catch (e) {} + } catch {} throw createValidationError( ` ${humanOptionName} ${chalk.bold( diff --git a/packages/jest-config/src/validatePattern.ts b/packages/jest-config/src/validatePattern.ts index b132e09c0a6c..59e310f2f5a5 100644 --- a/packages/jest-config/src/validatePattern.ts +++ b/packages/jest-config/src/validatePattern.ts @@ -10,7 +10,7 @@ export default function validatePattern(pattern?: string): boolean { try { // eslint-disable-next-line no-new new RegExp(pattern, 'i'); - } catch (e) { + } catch { return false; } } diff --git a/packages/jest-core/src/TestNamePatternPrompt.ts b/packages/jest-core/src/TestNamePatternPrompt.ts index 323a73835842..8fd02b108501 100644 --- a/packages/jest-core/src/TestNamePatternPrompt.ts +++ b/packages/jest-core/src/TestNamePatternPrompt.ts @@ -40,7 +40,7 @@ export default class TestNamePatternPrompt extends PatternPrompt { try { regex = new RegExp(pattern, 'i'); - } catch (e) { + } catch { return []; } diff --git a/packages/jest-core/src/TestPathPatternPrompt.ts b/packages/jest-core/src/TestPathPatternPrompt.ts index 59ad72e8aed1..7e6622e23335 100644 --- a/packages/jest-core/src/TestPathPatternPrompt.ts +++ b/packages/jest-core/src/TestPathPatternPrompt.ts @@ -47,7 +47,7 @@ export default class TestPathPatternPrompt extends PatternPrompt { try { regex = new RegExp(pattern, 'i'); - } catch (e) {} + } catch {} let tests: Array = []; if (regex && this._searchSources) { diff --git a/packages/jest-core/src/cli/index.ts b/packages/jest-core/src/cli/index.ts index a1082d079f1c..f74cb49fdd94 100644 --- a/packages/jest-core/src/cli/index.ts +++ b/packages/jest-core/src/cli/index.ts @@ -238,7 +238,7 @@ const runWatch = async ( undefined, filter, ); - } catch (e) { + } catch { exit(0); } } diff --git a/packages/jest-diff/src/index.ts b/packages/jest-diff/src/index.ts index d8d3bb0d1dea..fd0e680eea03 100644 --- a/packages/jest-diff/src/index.ts +++ b/packages/jest-diff/src/index.ts @@ -154,7 +154,7 @@ function compareObjects( options, ); } - } catch (e) { + } catch { hasThrown = true; } diff --git a/packages/jest-haste-map/src/__tests__/index.test.js b/packages/jest-haste-map/src/__tests__/index.test.js index d99e22aa25d9..0ddddf58895b 100644 --- a/packages/jest-haste-map/src/__tests__/index.test.js +++ b/packages/jest-haste-map/src/__tests__/index.test.js @@ -1385,7 +1385,7 @@ describe('HasteMap', () => { describe('file system changes processing', () => { function waitForItToChange(hasteMap) { - return new Promise((resolve, reject) => { + return new Promise(resolve => { hasteMap.once('change', resolve); }); } diff --git a/packages/jest-haste-map/src/index.ts b/packages/jest-haste-map/src/index.ts index 8de73059e305..367f2060846e 100644 --- a/packages/jest-haste-map/src/index.ts +++ b/packages/jest-haste-map/src/index.ts @@ -126,7 +126,7 @@ const canUseWatchman = ((): boolean => { try { execSync('watchman --version', {stdio: ['ignore']}); return true; - } catch (e) {} + } catch {} return false; })(); @@ -381,7 +381,7 @@ class HasteMap extends EventEmitter { try { hasteMap = serializer.readFileSync(this._cachePath); - } catch (err) { + } catch { hasteMap = this._createEmptyMap(); } diff --git a/packages/jest-haste-map/src/lib/FSEventsWatcher.ts b/packages/jest-haste-map/src/lib/FSEventsWatcher.ts index 2cf05da9655b..6d382459f36f 100644 --- a/packages/jest-haste-map/src/lib/FSEventsWatcher.ts +++ b/packages/jest-haste-map/src/lib/FSEventsWatcher.ts @@ -19,7 +19,7 @@ import walker from 'walker'; let fsevents: typeof import('fsevents') | null = null; try { fsevents = require('fsevents'); -} catch (e) { +} catch { // Optional dependency, only supported on Darwin. } diff --git a/packages/jest-haste-map/src/lib/isRegExpSupported.ts b/packages/jest-haste-map/src/lib/isRegExpSupported.ts index 9f35631ae46d..b8db382928f3 100644 --- a/packages/jest-haste-map/src/lib/isRegExpSupported.ts +++ b/packages/jest-haste-map/src/lib/isRegExpSupported.ts @@ -10,7 +10,7 @@ export default function isRegExpSupported(value: string): boolean { // eslint-disable-next-line no-new new RegExp(value); return true; - } catch (e) { + } catch { return false; } } diff --git a/packages/jest-jasmine2/src/__tests__/pTimeout.test.ts b/packages/jest-jasmine2/src/__tests__/pTimeout.test.ts index e31c59df0eb0..d5099ba0f03d 100644 --- a/packages/jest-jasmine2/src/__tests__/pTimeout.test.ts +++ b/packages/jest-jasmine2/src/__tests__/pTimeout.test.ts @@ -30,7 +30,7 @@ describe('pTimeout', () => { const promise = Promise.reject(); try { await pTimeout(promise, 1000, clearTimeout, setTimeout, onTimeout); - } catch (e) {} + } catch {} expect(setTimeout).toHaveBeenCalled(); expect(clearTimeout).toHaveBeenCalled(); expect(onTimeout).not.toHaveBeenCalled(); diff --git a/packages/jest-jasmine2/src/jasmine/Suite.ts b/packages/jest-jasmine2/src/jasmine/Suite.ts index 70259aefc552..d07d6aa7627e 100644 --- a/packages/jest-jasmine2/src/jasmine/Suite.ts +++ b/packages/jest-jasmine2/src/jasmine/Suite.ts @@ -207,7 +207,7 @@ export default class Suite { const child = this.children[i]; try { child.addExpectationResult.apply(child, args); - } catch (e) { + } catch { // keep going } } diff --git a/packages/jest-jasmine2/src/jasmine/spyRegistry.ts b/packages/jest-jasmine2/src/jasmine/spyRegistry.ts index ae06e396650f..6b7d4ecf0081 100644 --- a/packages/jest-jasmine2/src/jasmine/spyRegistry.ts +++ b/packages/jest-jasmine2/src/jasmine/spyRegistry.ts @@ -113,7 +113,7 @@ export default class SpyRegistry { let descriptor; try { descriptor = Object.getOwnPropertyDescriptor(obj, methodName); - } catch (e) { + } catch { // IE 8 doesn't support `definePropery` on non-DOM nodes } @@ -166,7 +166,7 @@ export default class SpyRegistry { let descriptor: PropertyDescriptor | undefined; try { descriptor = Object.getOwnPropertyDescriptor(obj, propertyName); - } catch (e) { + } catch { // IE 8 doesn't support `definePropery` on non-DOM nodes } diff --git a/packages/jest-matcher-utils/src/index.ts b/packages/jest-matcher-utils/src/index.ts index ce0de43db9ef..46858795ea9d 100644 --- a/packages/jest-matcher-utils/src/index.ts +++ b/packages/jest-matcher-utils/src/index.ts @@ -93,7 +93,7 @@ export const stringify = (object: unknown, maxDepth: number = 10): string => { min: true, plugins: PLUGINS, }); - } catch (e) { + } catch { result = prettyFormat(object, { callToJSON: false, maxDepth, diff --git a/packages/jest-message-util/src/index.ts b/packages/jest-message-util/src/index.ts index 4b49f66dab5d..ca48e129fd50 100644 --- a/packages/jest-message-util/src/index.ts +++ b/packages/jest-message-util/src/index.ts @@ -26,7 +26,7 @@ let nodeInternals: Array = []; try { nodeInternals = StackUtils.nodeInternals(); -} catch (e) { +} catch { // `StackUtils.nodeInternals()` fails in browsers. We don't need to remove // node internals in the browser though, so no issue. } @@ -295,7 +295,7 @@ export const formatStackTrace = ( // see: https://github.com/facebook/jest/pull/5405#discussion_r164281696 fileContent = fs.readFileSync(filename, 'utf8'); renderedCallsite = getRenderedCallsite(fileContent, line, column); - } catch (e) { + } catch { // the file does not exist or is inaccessible, we ignore } } diff --git a/packages/jest-mock/src/__tests__/index.test.ts b/packages/jest-mock/src/__tests__/index.test.ts index bd7b073351e4..16f5a5e1f425 100644 --- a/packages/jest-mock/src/__tests__/index.test.ts +++ b/packages/jest-mock/src/__tests__/index.test.ts @@ -765,7 +765,7 @@ describe('moduleMocker', () => { try { fn(2, 4); - } catch (error) { + } catch { // ignore error } diff --git a/packages/jest-reporters/src/coverage_reporter.ts b/packages/jest-reporters/src/coverage_reporter.ts index 8d381576a445..1faad089806e 100644 --- a/packages/jest-reporters/src/coverage_reporter.ts +++ b/packages/jest-reporters/src/coverage_reporter.ts @@ -212,7 +212,7 @@ export default class CoverageReporter extends BaseReporter { try { await Promise.all(instrumentation); - } catch (err) { + } catch { // Do nothing; errors were reported earlier to the console. } diff --git a/packages/jest-resolve/src/nodeModulesPaths.ts b/packages/jest-resolve/src/nodeModulesPaths.ts index 1c311b70df52..604e071c01fe 100644 --- a/packages/jest-resolve/src/nodeModulesPaths.ts +++ b/packages/jest-resolve/src/nodeModulesPaths.ts @@ -41,7 +41,7 @@ export default function nodeModulesPaths( let physicalBasedir; try { physicalBasedir = tryRealpath(basedirAbs); - } catch (err) { + } catch { // realpath can throw, e.g. on mapped drives physicalBasedir = basedirAbs; } diff --git a/packages/jest-runner/src/runTest.ts b/packages/jest-runner/src/runTest.ts index e1745f1e8917..dedd560cc12c 100644 --- a/packages/jest-runner/src/runTest.ts +++ b/packages/jest-runner/src/runTest.ts @@ -183,7 +183,7 @@ async function runTestInternal( map: JSON.parse(fs.readFileSync(sourceMapSource, 'utf8')), url: source, }; - } catch (e) {} + } catch {} } return null; }, diff --git a/packages/jest-runtime/src/__tests__/test_root/__mocks__/ManuallyMocked.js b/packages/jest-runtime/src/__tests__/test_root/__mocks__/ManuallyMocked.js index f07bf5767193..02efd5e46724 100644 --- a/packages/jest-runtime/src/__tests__/test_root/__mocks__/ManuallyMocked.js +++ b/packages/jest-runtime/src/__tests__/test_root/__mocks__/ManuallyMocked.js @@ -12,7 +12,7 @@ let moduleStateValue = 'default'; try { OnlyRequiredFromMock = jest.requireActual('OnlyRequiredFromMock'); -} catch (e) { +} catch { // If the module cannot be loaded, use a dummy value. There is one test // that specifically tests for the correct value which ensures this feature // works. If the feature is broken, it doesn't cause additional log-spew in diff --git a/packages/jest-serializer/src/__tests__/index.test.ts b/packages/jest-serializer/src/__tests__/index.test.ts index 174e3de5067c..f97000d82623 100644 --- a/packages/jest-serializer/src/__tests__/index.test.ts +++ b/packages/jest-serializer/src/__tests__/index.test.ts @@ -35,7 +35,7 @@ const file = path.join(tmpdir(), '__jest-serialize-test__'); afterEach(() => { try { fs.unlinkSync(file); - } catch (err) { + } catch { // Do nothing if file does not exist. } }); diff --git a/packages/jest-snapshot/src/__tests__/mock_serializer.test.ts b/packages/jest-snapshot/src/__tests__/mock_serializer.test.ts index 527a7b6f7edf..993ee3aa9963 100644 --- a/packages/jest-snapshot/src/__tests__/mock_serializer.test.ts +++ b/packages/jest-snapshot/src/__tests__/mock_serializer.test.ts @@ -27,7 +27,7 @@ test('mock with 2 calls, 1 return, 1 throw', () => { try { fn(3); - } catch (error) { + } catch { // ignore error } diff --git a/packages/jest-snapshot/src/utils.ts b/packages/jest-snapshot/src/utils.ts index 20a62e79aa3c..a0ddb4e33268 100644 --- a/packages/jest-snapshot/src/utils.ts +++ b/packages/jest-snapshot/src/utils.ts @@ -105,7 +105,7 @@ export const getSnapshotData = ( // eslint-disable-next-line no-new-func const populate = new Function('exports', snapshotContents); populate(data); - } catch (e) {} + } catch {} } const validationResult = validateSnapshotVersion(snapshotContents); @@ -183,7 +183,7 @@ const printBacktickString = (str: string): string => export const ensureDirectoryExists = (filePath: Config.Path): void => { try { fs.mkdirSync(path.join(path.dirname(filePath)), {recursive: true}); - } catch (e) {} + } catch {} }; const normalizeNewlines = (string: string) => string.replace(/\r\n|\r/g, '\n'); diff --git a/packages/jest-source-map/src/getCallsite.ts b/packages/jest-source-map/src/getCallsite.ts index 863ce4327f94..0106c0ee0396 100644 --- a/packages/jest-source-map/src/getCallsite.ts +++ b/packages/jest-source-map/src/getCallsite.ts @@ -59,7 +59,7 @@ export default ( const sourceMap = readFileSync(sourceMapFileName, 'utf8'); // @ts-expect-error: Not allowed to pass string addSourceMapConsumer(stack, new SourceMapConsumer(sourceMap)); - } catch (e) { + } catch { // ignore } } diff --git a/packages/jest-test-sequencer/src/index.ts b/packages/jest-test-sequencer/src/index.ts index 95864c0ba62c..edad784a7059 100644 --- a/packages/jest-test-sequencer/src/index.ts +++ b/packages/jest-test-sequencer/src/index.ts @@ -49,7 +49,7 @@ export default class TestSequencer { context, JSON.parse(fs.readFileSync(cachePath, 'utf8')), ); - } catch (e) {} + } catch {} } } diff --git a/packages/jest-transform/src/ScriptTransformer.ts b/packages/jest-transform/src/ScriptTransformer.ts index fc4373c5fc48..c9500cc31bdf 100644 --- a/packages/jest-transform/src/ScriptTransformer.ts +++ b/packages/jest-transform/src/ScriptTransformer.ts @@ -332,7 +332,7 @@ export default class ScriptTransformer { if (inlineSourceMap) { transformed.map = inlineSourceMap.toObject(); } - } catch (e) { + } catch { const transformPath = this._getTransformPath(filename); console.warn( `jest-transform: The source map produced for the file ${filename} ` + @@ -607,7 +607,7 @@ export function createTranspilingRequire( const removeFile = (path: Config.Path) => { try { fs.unlinkSync(path); - } catch (e) {} + } catch {} }; const stripShebang = (content: string) => { diff --git a/packages/jest-watcher/src/lib/formatTestNameByPattern.ts b/packages/jest-watcher/src/lib/formatTestNameByPattern.ts index f4aa60f93443..a470bf4ad4f0 100644 --- a/packages/jest-watcher/src/lib/formatTestNameByPattern.ts +++ b/packages/jest-watcher/src/lib/formatTestNameByPattern.ts @@ -19,7 +19,7 @@ export default (testName: string, pattern: string, width: number): string => { try { regexp = new RegExp(pattern, 'i'); - } catch (e) { + } catch { return chalk.dim(inlineTestName); } diff --git a/packages/jest-worker/src/__performance_tests__/test.js b/packages/jest-worker/src/__performance_tests__/test.js index 911b8608bec8..23b5fd1c585f 100644 --- a/packages/jest-worker/src/__performance_tests__/test.js +++ b/packages/jest-worker/src/__performance_tests__/test.js @@ -23,7 +23,7 @@ const calls = +process.argv[3]; const threads = 6; function testWorkerFarm() { - return new Promise(async (resolve, reject) => { + return new Promise(async resolve => { const startTime = Date.now(); let count = 0; @@ -74,7 +74,7 @@ function testWorkerFarm() { } function testJestWorker() { - return new Promise(async (resolve, reject) => { + return new Promise(async resolve => { const startTime = Date.now(); let count = 0; diff --git a/packages/jest-worker/src/workers/__tests__/processChild.test.js b/packages/jest-worker/src/workers/__tests__/processChild.test.js index c1dd240d525c..ba579e052efe 100644 --- a/packages/jest-worker/src/workers/__tests__/processChild.test.js +++ b/packages/jest-worker/src/workers/__tests__/processChild.test.js @@ -43,7 +43,7 @@ beforeEach(() => { }, fooPromiseWorks() { - return new Promise((resolve, reject) => { + return new Promise(resolve => { setTimeout(() => resolve(1989), 5); }); }, diff --git a/packages/jest-worker/src/workers/__tests__/threadChild.test.js b/packages/jest-worker/src/workers/__tests__/threadChild.test.js index d62fedffc084..e22a5d679cb5 100644 --- a/packages/jest-worker/src/workers/__tests__/threadChild.test.js +++ b/packages/jest-worker/src/workers/__tests__/threadChild.test.js @@ -53,7 +53,7 @@ beforeEach(() => { }, fooPromiseWorks() { - return new Promise((resolve, reject) => { + return new Promise(resolve => { setTimeout(() => resolve(1989), 5); }); }, diff --git a/packages/jest-worker/src/workers/messageParent.ts b/packages/jest-worker/src/workers/messageParent.ts index f9281bea4b0b..bf0f828cbb63 100644 --- a/packages/jest-worker/src/workers/messageParent.ts +++ b/packages/jest-worker/src/workers/messageParent.ts @@ -29,7 +29,7 @@ const messageParent = ( } else if (typeof parentProcess.send === 'function') { parentProcess.send([PARENT_MESSAGE_CUSTOM, message]); } - } catch (error) { + } catch { throw new Error('"messageParent" can only be used inside a worker'); } }; diff --git a/scripts/watch.js b/scripts/watch.js index 5af9c3ee9b50..9bdb873a537e 100644 --- a/scripts/watch.js +++ b/scripts/watch.js @@ -23,7 +23,7 @@ let filesToBuild = new Map(); const exists = filename => { try { return fs.statSync(filename).isFile(); - } catch (e) {} + } catch {} return false; }; const rebuild = filename => filesToBuild.set(filename, true); @@ -62,7 +62,7 @@ chokidar buildFile, )} (deleted)\n`, ); - } catch (e) {} + } catch {} } }); @@ -72,7 +72,7 @@ setInterval(() => { filesToBuild = new Map(); try { execSync(`${BUILD_CMD} ${files.join(' ')}`, {stdio: [0, 1, 2]}); - } catch (e) {} + } catch {} } }, 100);