From 6ea17f5dcdebe878cfc4ffeeea6ae298875cd883 Mon Sep 17 00:00:00 2001 From: victorphoenix3 Date: Tue, 6 Oct 2020 05:42:24 +0530 Subject: [PATCH] validate testURL as CLI option --- CHANGELOG.md | 2 ++ .../src/__tests__/validateCLIOptions.test.js | 13 +++++++++++++ packages/jest-validate/src/validateCLIOptions.ts | 1 + 3 files changed, 16 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f29887d759a1..876bec0ddf72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ ## master +- `[jest-validate]` Validate `testURL` as CLI option ([#10595](https://github.com/facebook/jest/pull/10595)) + ### Features ### Fixes diff --git a/packages/jest-validate/src/__tests__/validateCLIOptions.test.js b/packages/jest-validate/src/__tests__/validateCLIOptions.test.js index 5a4dabfbcf9c..73a14cba7176 100644 --- a/packages/jest-validate/src/__tests__/validateCLIOptions.test.js +++ b/packages/jest-validate/src/__tests__/validateCLIOptions.test.js @@ -19,6 +19,19 @@ test('validates yargs special options', () => { expect(validateCLIOptions(argv, options)).toBe(true); }); +test('validates testURL', () => { + const options = { + testURL: { + description: 'This option sets the URL for the jsdom environment.', + type: 'string', + }, + }; + const argv = { + testURL: 'http://localhost', + }; + expect(validateCLIOptions(argv, options)).toBe(true); +}); + test('fails for unknown option', () => { const options = ['$0', '_', 'help', 'h']; const argv = { diff --git a/packages/jest-validate/src/validateCLIOptions.ts b/packages/jest-validate/src/validateCLIOptions.ts index 72ad11aef1c9..8ca2a6a96dbe 100644 --- a/packages/jest-validate/src/validateCLIOptions.ts +++ b/packages/jest-validate/src/validateCLIOptions.ts @@ -79,6 +79,7 @@ export default function validateCLIOptions( const unrecognizedOptions = Object.keys(argv).filter( arg => !allowedOptions.has(camelcase(arg)) && + !allowedOptions.has(arg) && (!rawArgv.length || rawArgv.includes(arg)), [], );