From 5e966da40e36ac851f9e4d44c4d63dd818cc07fe Mon Sep 17 00:00:00 2001
From: victorphoenix3 <gaurijove@gmail.com>
Date: Tue, 6 Oct 2020 05:42:24 +0530
Subject: [PATCH] validate testURL as CLI option

---
 CHANGELOG.md                                        |  1 +
 .../src/__tests__/validateCLIOptions.test.js        | 13 +++++++++++++
 packages/jest-validate/src/validateCLIOptions.ts    |  1 +
 3 files changed, 15 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f29887d759a1..2b8b0fe59582 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -29,6 +29,7 @@
 - `[jest-console]` Add `Console` constructor to `console` object ([#10502](https://github.com/facebook/jest/pull/10502))
 - `[jest-globals]` Fix lifecycle hook function types ([#10480](https://github.com/facebook/jest/pull/10480))
 - `[jest-runtime]` Remove usage of `vm.compileFunction` due to a performance issue ([#10586](https://github.com/facebook/jest/pull/10586))
+- `[jest-validate]` Validate `testURL` as CLI option ([#10595](https://github.com/facebook/jest/pull/10595))
 
 ### Chore & Maintenance
 
diff --git a/packages/jest-validate/src/__tests__/validateCLIOptions.test.js b/packages/jest-validate/src/__tests__/validateCLIOptions.test.js
index 5a4dabfbcf9c..73a14cba7176 100644
--- a/packages/jest-validate/src/__tests__/validateCLIOptions.test.js
+++ b/packages/jest-validate/src/__tests__/validateCLIOptions.test.js
@@ -19,6 +19,19 @@ test('validates yargs special options', () => {
   expect(validateCLIOptions(argv, options)).toBe(true);
 });
 
+test('validates testURL', () => {
+  const options = {
+    testURL: {
+      description: 'This option sets the URL for the jsdom environment.',
+      type: 'string',
+    },
+  };
+  const argv = {
+    testURL: 'http://localhost',
+  };
+  expect(validateCLIOptions(argv, options)).toBe(true);
+});
+
 test('fails for unknown option', () => {
   const options = ['$0', '_', 'help', 'h'];
   const argv = {
diff --git a/packages/jest-validate/src/validateCLIOptions.ts b/packages/jest-validate/src/validateCLIOptions.ts
index 72ad11aef1c9..8ca2a6a96dbe 100644
--- a/packages/jest-validate/src/validateCLIOptions.ts
+++ b/packages/jest-validate/src/validateCLIOptions.ts
@@ -79,6 +79,7 @@ export default function validateCLIOptions(
   const unrecognizedOptions = Object.keys(argv).filter(
     arg =>
       !allowedOptions.has(camelcase(arg)) &&
+      !allowedOptions.has(arg) &&
       (!rawArgv.length || rawArgv.includes(arg)),
     [],
   );