Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow adding custom properties to <testcase> #246

Closed
eps1lon opened this issue Mar 20, 2023 · 2 comments · Fixed by #247
Closed

Feature Request: Allow adding custom properties to <testcase> #246

eps1lon opened this issue Mar 20, 2023 · 2 comments · Fixed by #247

Comments

@eps1lon
Copy link
Contributor

eps1lon commented Mar 20, 2023

Similar to custom <properties> in <testsuite>, this would allow adding properties to <testcase>. This would allow adding metadata to individual tests in DataDog (see https://docs.datadoghq.com/continuous_integration/tests/junit_upload/?tab=jenkins#providing-metadata-through-property-elements).

The main motivation is adding the number of test invocations (see #157).

I understand that <properties> inside <testcase> would violate standard JUnit XSD but seems like this package is open to adding non-standard XML (e.g. #228).

I already have a patch locally that we're using at Klarna and will propose it as a PR once we've tested it internally.

@palmerj3
Copy link
Collaborator

Nice!

I'll happily review any PRs I see. So long as non-standard XML is gated behind a configuration option I'm fine with it.

@eps1lon
Copy link
Contributor Author

eps1lon commented Mar 22, 2023

@palmerj3 Opened #247 which needs approval to run CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants