Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of uniqueOutputName to use a specified prefix rather than just junit-uuid.xml #203

Merged
merged 3 commits into from Apr 12, 2022

Conversation

mastrzyz
Copy link
Contributor

@mastrzyz mastrzyz commented Apr 1, 2022

We have very descriptive outputNames by default in our project like :

e2e-visual-tests-win32.xml

Currently we have a need to generate some with a unique UUID and would want something like :

e2e-visual-tests-win32-UUID.xml, unfortunately the uniqueOutputName has a hardcoded value : junit-UUID.xml

My proposal is to either leverage the outputName in tandem or to create a new option uniqueOutputPrefix so there is less Confusion? I'm happy to modify this PR to either.

@palmerj3
Copy link
Collaborator

palmerj3 commented Apr 1, 2022

Hi @mastrzyz thanks for the PR!

I like the idea and I'm mostly fine with the approach you've taken.
My concern is primarily the xml validation being turned off, as I commented.

I use that for the tests to ensure every test outputs a junit file that is compatible with the jenkins spec so it's critical.

Take a look and see if you can get things passing in CI then I'll give it another look.

@mastrzyz
Copy link
Contributor Author

mastrzyz commented Apr 1, 2022

Apologies palamer , had big problems with running with those locally and the UT's, yes will remove them so they don't get accidentally merged in!

@mastrzyz
Copy link
Contributor Author

Fixed! although the CI Build is broken due to a flaky yarn install issue?

@palmerj3
Copy link
Collaborator

Yeah the windows build isn't working for some reason. I'm going to remove it, I think. Merging now and I'll push a new version shortly.

Thank you!

@palmerj3 palmerj3 merged commit 1b91ee8 into jest-community:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants