Add outputFile config and tests #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daivinhtran
force-pushed
the
add-outputfile-config
branch
2 times, most recently
from
1f18e64
to
1f6057c
Compare
daivinhtran
force-pushed
the
add-outputfile-config
branch
from
1f6057c
to
3c68d50
Compare
daivinhtran
commented
May 25, 2021
| @@ -23,17 +24,13 @@ const processor = (report, reporterOptions = {}, jestRootDir = null) => { | |||
|
|
|||
| const jsonResults = buildJsonResults(report, fs.realpathSync(process.cwd()), options); | |||
|
|
|||
| // Set output to use new outputDirectory and fallback on original output | |||
There was a problem hiding this comment.
This block is refactored into ./utils.getOutputPath.js for cleaniness. I can move it back if you prefer it that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #167, I added
outputFileandJEST_JUNIT_OUTPUT_FILEwhich will overrideoutputDirectoryandoutputNameif defined.One of the use cases for this feature is when using with Bazel, we need the fullpath to the output to be dynamically defined by bazel.
Closes #167