Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of fail clashes with vitest #554

Closed
simon-abbott opened this issue Jan 25, 2023 · 3 comments
Closed

Type of fail clashes with vitest #554

simon-abbott opened this issue Jan 25, 2023 · 3 comments

Comments

@simon-abbott
Copy link

#549 supposedly added support for vitest, but when I try to use the types it fails with the error Named property 'fail' of types 'ExpectStatic' and 'AsymmetricMatchersContaining' are not identical.

Since the pass and fail matchers are not implemented, could those definitions just be removed?
@SimenB
Copy link
Member

SimenB commented Jan 25, 2023

Sure. Should clean up docs as well. Wanna send a PR?

@simon-abbott
Copy link
Author

Hmm. Upon closer review it seems that it's more complicated that that... I'll open a PR, but it's going to take some refactoring.

@simon-abbott
Copy link
Author

I updated to the latest version of vitest and it seems to work now. I guess vitest changed something. Either way this appears to no longer be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @simon-abbott