From 2cbe86628d12c97fc566628c697d036ade133ee4 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Fri, 15 Oct 2021 13:29:01 +0200 Subject: [PATCH 1/3] chore: bump `eslint-plugin-eslint-plugin` --- package.json | 2 +- yarn.lock | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index a741d8026..67a0d7db1 100644 --- a/package.json +++ b/package.json @@ -107,7 +107,7 @@ "eslint-config-prettier": "^8.3.0", "eslint-plugin-eslint-comments": "^3.1.2", "eslint-plugin-eslint-config": "^2.0.0", - "eslint-plugin-eslint-plugin": "^3.5.3", + "eslint-plugin-eslint-plugin": "^4.0.0", "eslint-plugin-import": "^2.25.1", "eslint-plugin-node": "^11.0.0", "eslint-plugin-prettier": "^3.4.1", diff --git a/yarn.lock b/yarn.lock index 090479b83..049b71c75 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4342,14 +4342,15 @@ __metadata: languageName: node linkType: hard -"eslint-plugin-eslint-plugin@npm:^3.5.3": - version: 3.6.1 - resolution: "eslint-plugin-eslint-plugin@npm:3.6.1" +"eslint-plugin-eslint-plugin@npm:^4.0.0": + version: 4.0.0 + resolution: "eslint-plugin-eslint-plugin@npm:4.0.0" dependencies: - eslint-utils: ^2.1.0 + eslint-utils: ^3.0.0 + estraverse: ^5.2.0 peerDependencies: eslint: ">=6.0.0" - checksum: 178fef88197c43d554f132fdfed11217d0ba77431d193642119a3d5fe1acc91d1f02923bef60c0faf3f6bd93f54e6eb51e83e2625dfc98cb2a33d4ebdaa6ab81 + checksum: 7b17ee72bf2b8c21878529a6b49af3934a6cc43e39ffb2623fbe1361c1943ca240909b0208a60fba071da781a3b601f713312ef0275e97a44e290b433b73b600 languageName: node linkType: hard @@ -4403,7 +4404,7 @@ __metadata: eslint-config-prettier: ^8.3.0 eslint-plugin-eslint-comments: ^3.1.2 eslint-plugin-eslint-config: ^2.0.0 - eslint-plugin-eslint-plugin: ^3.5.3 + eslint-plugin-eslint-plugin: ^4.0.0 eslint-plugin-import: ^2.25.1 eslint-plugin-node: ^11.0.0 eslint-plugin-prettier: ^3.4.1 @@ -4479,7 +4480,7 @@ __metadata: languageName: node linkType: hard -"eslint-utils@npm:^2.0.0, eslint-utils@npm:^2.1.0": +"eslint-utils@npm:^2.0.0": version: 2.1.0 resolution: "eslint-utils@npm:2.1.0" dependencies: From 4ea89bad73c62246d05923ef097b6da6bf264c24 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Fri, 15 Oct 2021 13:35:06 +0200 Subject: [PATCH 2/3] chore: add missing `output: null` --- src/rules/__tests__/no-jasmine-globals.test.ts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/rules/__tests__/no-jasmine-globals.test.ts b/src/rules/__tests__/no-jasmine-globals.test.ts index b2e93f820..871d31c33 100644 --- a/src/rules/__tests__/no-jasmine-globals.test.ts +++ b/src/rules/__tests__/no-jasmine-globals.test.ts @@ -21,6 +21,7 @@ ruleTester.run('no-jasmine-globals', rule, { invalid: [ { code: 'spyOn(some, "object")', + output: null, errors: [ { messageId: 'illegalGlobal', @@ -32,6 +33,7 @@ ruleTester.run('no-jasmine-globals', rule, { }, { code: 'spyOnProperty(some, "object")', + output: null, errors: [ { messageId: 'illegalGlobal', @@ -43,10 +45,12 @@ ruleTester.run('no-jasmine-globals', rule, { }, { code: 'fail()', + output: null, errors: [{ messageId: 'illegalFail', column: 1, line: 1 }], }, { code: 'pending()', + output: null, errors: [{ messageId: 'illegalPending', column: 1, line: 1 }], }, { @@ -56,10 +60,12 @@ ruleTester.run('no-jasmine-globals', rule, { }, { code: 'jasmine.DEFAULT_TIMEOUT_INTERVAL = function() {}', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, { code: 'jasmine.addMatchers(matchers)', + output: null, errors: [ { messageId: 'illegalMethod', @@ -71,6 +77,7 @@ ruleTester.run('no-jasmine-globals', rule, { }, { code: 'jasmine.createSpy()', + output: null, errors: [ { messageId: 'illegalMethod', @@ -151,30 +158,37 @@ ruleTester.run('no-jasmine-globals', rule, { }, { code: 'jasmine.getEnv()', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, { code: 'jasmine.empty()', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, { code: 'jasmine.falsy()', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, { code: 'jasmine.truthy()', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, { code: 'jasmine.arrayWithExactContents()', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, { code: 'jasmine.clock()', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, { code: 'jasmine.MAX_PRETTY_PRINT_ARRAY_LENGTH = 42', + output: null, errors: [{ messageId: 'illegalJasmine', column: 1, line: 1 }], }, ], From e693647b91481f4017a8e7381703a4405ee1f08a Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Fri, 15 Oct 2021 15:30:31 +0200 Subject: [PATCH 3/3] chore: 4.0.1 --- package.json | 2 +- yarn.lock | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 67a0d7db1..61a9ecce2 100644 --- a/package.json +++ b/package.json @@ -107,7 +107,7 @@ "eslint-config-prettier": "^8.3.0", "eslint-plugin-eslint-comments": "^3.1.2", "eslint-plugin-eslint-config": "^2.0.0", - "eslint-plugin-eslint-plugin": "^4.0.0", + "eslint-plugin-eslint-plugin": "^4.0.1", "eslint-plugin-import": "^2.25.1", "eslint-plugin-node": "^11.0.0", "eslint-plugin-prettier": "^3.4.1", diff --git a/yarn.lock b/yarn.lock index 049b71c75..9e4b1b032 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4342,15 +4342,15 @@ __metadata: languageName: node linkType: hard -"eslint-plugin-eslint-plugin@npm:^4.0.0": - version: 4.0.0 - resolution: "eslint-plugin-eslint-plugin@npm:4.0.0" +"eslint-plugin-eslint-plugin@npm:^4.0.1": + version: 4.0.1 + resolution: "eslint-plugin-eslint-plugin@npm:4.0.1" dependencies: eslint-utils: ^3.0.0 estraverse: ^5.2.0 peerDependencies: eslint: ">=6.0.0" - checksum: 7b17ee72bf2b8c21878529a6b49af3934a6cc43e39ffb2623fbe1361c1943ca240909b0208a60fba071da781a3b601f713312ef0275e97a44e290b433b73b600 + checksum: f71418d522e8dde7f378ef6856b35281d6dfa5f5f9028f9d0d8fd762e13b92260f95a81d000b13b645a83b799cc821a2b200366cd5abccaaeccfbb1e767f872a languageName: node linkType: hard @@ -4404,7 +4404,7 @@ __metadata: eslint-config-prettier: ^8.3.0 eslint-plugin-eslint-comments: ^3.1.2 eslint-plugin-eslint-config: ^2.0.0 - eslint-plugin-eslint-plugin: ^4.0.0 + eslint-plugin-eslint-plugin: ^4.0.1 eslint-plugin-import: ^2.25.1 eslint-plugin-node: ^11.0.0 eslint-plugin-prettier: ^3.4.1