From 1b1513c08a7e62482f9b17aace8fa4fff514e93a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 31 Jan 2024 18:13:07 +0000 Subject: [PATCH 01/10] chore(deps): update codecov/codecov-action action to v4 --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index f21b9cf6d..21849cbd2 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -100,7 +100,7 @@ jobs: run: yarn test --coverage ${{ matrix.eslint-version >= 8 }} env: CI: true - - uses: codecov/codecov-action@v3 + - uses: codecov/codecov-action@v4 if: ${{ matrix.eslint-version >= 8 }} test-ubuntu: uses: ./.github/workflows/test.yml From 66465d4ac7c682e34d76fe5ed477895b63d5f5fb Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Fri, 2 Feb 2024 08:39:56 +0100 Subject: [PATCH 02/10] ci: include secret --- .github/workflows/nodejs.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 21849cbd2..bdc0fa31f 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -102,6 +102,8 @@ jobs: CI: true - uses: codecov/codecov-action@v4 if: ${{ matrix.eslint-version >= 8 }} + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} test-ubuntu: uses: ./.github/workflows/test.yml needs: prepare-yarn-cache-ubuntu From 74085c057dd307a9a2788b1c3f90f300338dd32f Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 26 Apr 2024 07:51:28 +1200 Subject: [PATCH 03/10] ci: try using `with` instead --- .github/workflows/nodejs.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index b3dd2d2e5..79a1381b8 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -108,8 +108,9 @@ jobs: CI: true - uses: codecov/codecov-action@v4 if: ${{ matrix.eslint-version >= 8 }} - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + with: + codecov_token: ${{ secrets.CODECOV_TOKEN }} + fail_ci_if_error: true test-ubuntu: uses: ./.github/workflows/test.yml needs: prepare-yarn-cache-ubuntu From 34232e9bd83a48e799c58c5250443e4553183f55 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 26 Apr 2024 07:53:32 +1200 Subject: [PATCH 04/10] ci: `token` not `codecov_token` --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 79a1381b8..5258c6838 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -109,7 +109,7 @@ jobs: - uses: codecov/codecov-action@v4 if: ${{ matrix.eslint-version >= 8 }} with: - codecov_token: ${{ secrets.CODECOV_TOKEN }} + token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true test-ubuntu: uses: ./.github/workflows/test.yml From 92e8b671d76e45e6e9449c0b9685c56cc388d2c7 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 26 Apr 2024 07:59:31 +1200 Subject: [PATCH 05/10] ci: explicitly don't use OIDC for codecov uploads --- .github/workflows/nodejs.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 5258c6838..f8eb48409 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -111,6 +111,7 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true + use_oidc: false test-ubuntu: uses: ./.github/workflows/test.yml needs: prepare-yarn-cache-ubuntu From aabda4c2edc3988df0282f80de112eaa2e219429 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 26 Apr 2024 08:05:16 +1200 Subject: [PATCH 06/10] ci: pin `codecov` to v4.1.1 --- .github/workflows/nodejs.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index f8eb48409..3109bc9bc 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -106,12 +106,11 @@ jobs: run: yarn test --coverage ${{ matrix.eslint-version == 8 }} env: CI: true - - uses: codecov/codecov-action@v4 + - uses: codecov/codecov-action@v4.1.1 if: ${{ matrix.eslint-version >= 8 }} with: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true - use_oidc: false test-ubuntu: uses: ./.github/workflows/test.yml needs: prepare-yarn-cache-ubuntu From c715c0d3e69a13975fa3f60e12235e4cf21f6f2d Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 26 Apr 2024 09:48:38 +1200 Subject: [PATCH 07/10] ci: purposely use an invalid token --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 3109bc9bc..9dee327fd 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -109,7 +109,7 @@ jobs: - uses: codecov/codecov-action@v4.1.1 if: ${{ matrix.eslint-version >= 8 }} with: - token: ${{ secrets.CODECOV_TOKEN }} + token: 'blahblah' fail_ci_if_error: true test-ubuntu: uses: ./.github/workflows/test.yml From fa3ab788834ba7100d588e0425b4de79724cd603 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 30 Apr 2024 11:33:30 +0200 Subject: [PATCH 08/10] actually use token --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 66ce27be1..dae981a9f 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -109,7 +109,7 @@ jobs: - uses: codecov/codecov-action@v4.1.1 if: ${{ matrix.eslint-version >= 8 }} with: - token: 'blahblah' + token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true test-ubuntu: uses: ./.github/workflows/test.yml From 564ce4084b6920ae3400599476cd6bfb23506511 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 30 Apr 2024 11:33:47 +0200 Subject: [PATCH 09/10] only specify major --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index dae981a9f..5998dda4f 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -106,7 +106,7 @@ jobs: run: yarn test --coverage ${{ matrix.eslint-version == 8 }} env: CI: true - - uses: codecov/codecov-action@v4.1.1 + - uses: codecov/codecov-action@v4 if: ${{ matrix.eslint-version >= 8 }} with: token: ${{ secrets.CODECOV_TOKEN }} From f9f14ebaa07c1e800bb5c3e0b97d2c0f57d5b755 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Sun, 12 May 2024 20:58:31 +0200 Subject: [PATCH 10/10] Update nodejs.yml --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 4cc495b78..cc21dd7c7 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -108,7 +108,7 @@ jobs: env: CI: true - uses: codecov/codecov-action@v4 - if: ${{ matrix.eslint-version >= 8 }} + if: ${{ matrix.eslint-version == 8 }} with: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true