Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(valid-expect-in-promise): allow expect.resolve & expect.reject #948

Merged
merged 1 commit into from Oct 14, 2021
Merged

fix(valid-expect-in-promise): allow expect.resolve & expect.reject #948

merged 1 commit into from Oct 14, 2021

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 12, 2021

We purposely don't check if the expect is awaited or returned, as
that is the role of the valid-expect rule.

Fixes #947

@G-Rath
fix(valid-expect-in-promise): allow expect.resolve & expect.reject
fdc02b1 
We purposely don't check if the `expect` is `await`ed or returned, as
that is the role of the `valid-expect` rule
SimenB
SimenB approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 👍

@SimenB SimenB merged commit 71b7e17 into main Oct 14, 2021
@SimenB SimenB deleted the valid-promise-adjustment branch October 14, 2021 06:54
github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 25.0.6 [skip ci]
a8a8ca2 
## [25.0.6](v25.0.5...v25.0.6) (2021-10-14)

### Bug Fixes

* **valid-expect-in-promise:** allow `expect.resolve` & `expect.reject` ([#948](#948)) ([71b7e17](71b7e17)), closes [#947](#947)
* **valid-expect-in-promise:** support `await` in arrays ([#949](#949)) ([a62130c](a62130c))
@github-actions
Copy link

🎉 This PR is included in version 25.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
bug released rule: valid-expect-in-promise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[valid-expect-in-promise] Another false positive
2 participants
@G-Rath @SimenB