[valid-expect-in-promise] Another false positive

[srmagura]

Hello, it's me again 😆. Thank you for the extremely quick fix to #930.

There are other cases where the rule is erroring even though the promise is (indirectly) awaited:

it("throws then resolves", async () => {
  const p = Promise.reject(new Error("myError")).then(undefined, (e) => {
    expect(e).toBeInstanceOf(Error);

    return "handled";
  });

  await expect(p).resolves.toBe("handled");
});

it("throws twice", async () => {
  const p = Promise.reject(new Error("myError")).then(undefined, (e) => {
    expect(e).toBeInstanceOf(Error);

    throw new Error("myError2");
  });

  await expect(p).rejects.toThrow("myError2");
});

  2:9  error  This promise should either be returned or awaited to ensure the expects in it's chain are called  jest/valid-expect-in-promise
  12:9  error  This promise should either be returned or awaited to ensure the expects in it's chain are called  jest/valid-expect-in-promise

Repository here

Versions

• "eslint": "^7.32.0",
• "eslint-plugin-jest": "^25.0.5"
• Node 14

[G-Rath]

ha cheers, I actually realised that one while working on #930, but didn't have the time to implement a fix - while generally we cannot support this case because we don't know how a function handles the promise it's being passed, we should make an exception for expect(...).resolves & expect(...).rejects since their "our" functions so do know how they should behave.

[github-actions]

🎉 This issue has been resolved in version 25.0.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀