chore(ci): make sure to only make new releases if tests pass

[SimenB]

https://github.com/jest-community/eslint-plugin-jest/runs/1914618070?check_suite_focus=true made a release even though tests were failing. #689 obviously didn't work, so let's bloat up a single file instead

I also added a prepare-yarn-cache job which ensures all other jobs have an updated cache before running

[SimenB]

Things happened in the correct order here - prepare-cache ran first, and only when that completed did all the tests runs spawn. The docs job also ran (it's supposed to only run on PRs, so will verify it does not run on master)

And release was skipped, but only showed up after the other jobs completed

[SimenB]

a failing test made no difference, it only said "skipped" still. Let's trust it works 😛 https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds

[G-Rath]

Sorry, I didn't realize we'd switched up CI like that - that explains why it released.

I played with the workflow event myself last month and couldn't find a way to have it only run on success

[SimenB]

Switched up? We've been using GH actions since Oct 2019 to make releases. And if you meant changes in #689 you did comment on them 😛

[G-Rath]

I meant #689 - the only comment j made in that PR was just now :)

(Unless the mobile UI is bidding previous comments?)

Still, no harm no foul 🤷‍♂️

[SimenB]

Regardless, seems fixed now

[SimenB]

I've also deprecated the broken release

https://www.npmjs.com/package/eslint-plugin-jest/v/24.1.4

[G-Rath]

Cheers - sorry again for the hassle 😓

[SimenB]

No worries, I'm the one who set up the broken automation 😀

[G-Rath]

Btw while I've got you, would you be good to turn on automatic deleting of head branches?

[SimenB]

Nice, didn't know GH had added that! I guess that happens automatically for me since I use refined GH.

Turned on both of these bad boys

[github-actions]

🎉 This PR is included in version 24.1.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀