Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated rules #661

Merged
merged 1 commit into from Sep 17, 2021
Merged

feat: remove deprecated rules #661

merged 1 commit into from Sep 17, 2021

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 5, 2020

BREAKING CHANGE

@G-Rath G-Rath requested a review from SimenB September 5, 2020 05:14
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate commit per rule so generated release log list each removed rule explicitly?

@G-Rath
Copy link
Collaborator Author

G-Rath commented Sep 5, 2020

I was just going to do a BREAKING CHANGE per rule in the commit body (I confirmed the changelog generator is fine with this for a similar situation last night, via this commit), but can do multiple commits if you'd prefer :)

---- edit

This is the changelog that resulted from that commit.

@SimenB
Copy link
Member

SimenB commented Sep 5, 2020

If the changelog has multiple entries I'm happy 👍

BREAKING CHANGE: remove `no-expect-resolves` rule
BREAKING CHANGE: remove `no-truthy-falsy` rule
BREAKING CHANGE: remove `no-try-expect` rule
BREAKING CHANGE: remove `prefer-inline-snapshots` rule
@G-Rath G-Rath marked this pull request as ready for review September 17, 2021 02:14
@G-Rath
Copy link
Collaborator Author

G-Rath commented Sep 17, 2021

@SimenB let's not forget this time 😅

@SimenB SimenB merged commit e8f16ec into next Sep 17, 2021
@SimenB SimenB deleted the remove-rules branch September 17, 2021 05:39
@SimenB
Copy link
Member

SimenB commented Sep 17, 2021

Let's not 😀

github-actions bot pushed a commit that referenced this pull request Sep 17, 2021
# [25.0.0-next.3](v25.0.0-next.2...v25.0.0-next.3) (2021-09-17)

### Features

* remove deprecated rules ([#661](#661)) ([e8f16ec](e8f16ec))

### BREAKING CHANGES

* Removes rules `no-expect-resolves`, `no-truthy-falsy`, `no-try-expect`, and `prefer-inline-snapshots`
@github-actions
Copy link

🎉 This PR is included in version 25.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Oct 10, 2021
# [25.0.0](v24.7.0...v25.0.0) (2021-10-10)

### Bug Fixes

* stop testing ESLint 5 ([#893](#893)) ([47a0138](47a0138))
* stop testing on Node 10 and 15 ([#891](#891)) ([bcd8d11](bcd8d11))

### Features

* add `prefer-to-be` to style ruleset ([2a3376f](2a3376f))
* **lowercase-name:** rename to `prefer-lowercase-title` ([b860084](b860084))
* **prefer-to-be-null:** remove rule ([809bcda](809bcda))
* **prefer-to-be-undefined:** remove rule ([3434d9b](3434d9b))
* remove deprecated rules ([#661](#661)) ([e8f16ec](e8f16ec))
* **valid-describe:** rename to `valid-describe-callback` ([f3e9e9a](f3e9e9a))

### BREAKING CHANGES

* **valid-describe:** renamed `valid-describe` to `valid-describe-callback`
* **lowercase-name:** renamed `lowercase-name` to `prefer-lowercase-title`
* **prefer-to-be-undefined:** removed `prefer-to-be-undefined` rule
* **prefer-to-be-null:** removed `prefer-to-be-null` rule
* recommend `prefer-to-be` rule
* Removes rules `no-expect-resolves`, `no-truthy-falsy`, `no-try-expect`, and `prefer-inline-snapshots`
* Drop support for ESLint 5
* Drop support for Node 10 and 15
@github-actions
Copy link

🎉 This PR is included in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants