chore: minor housekeeping #480
Merged
+108
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 23.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General house cleaning - removed some comments that are no longer needed, and chucked in
eslint-plugin-eslint-commentsb/c why not.Also refactored
no-alias-methodsto use a map instead of an array, which is technically slightly faster, but also just generally nicer logic-wise.Finally, fixed the message of
require-to-throw-messageto use the right data property :DThat also made me realise it could be a good candidate for the new suggestions api? provided it lets you take in user input.
@SimenB I adjusted the
eslintconfig to useeslint-config-prettier- let me know if I've just refactored away a work around for something?