Skip to content

chore(no-commented-out-tests): remove unneeded escape and improve regex #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 29, 2019

Super minor optimisations - [xf] is slightly faster than x|f, and lets us drop (), and ] doesn't need to be escaped.

Saves us a few bytes all round.

Copy link
Member

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@G-Rath G-Rath force-pushed the improve-no-commented-out-tests-regex branch from 16904a1 to ac5b143 Compare October 5, 2019 02:45
@G-Rath G-Rath merged commit e4275c5 into master Oct 5, 2019
@G-Rath G-Rath deleted the improve-no-commented-out-tests-regex branch October 5, 2019 03:57
@SimenB
Copy link
Member

SimenB commented Oct 12, 2019

🎉 This PR is included in version 22.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants