fix(tsutils): identify only valid global properties #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Jul 23, 2019
| @@ -96,6 +96,19 @@ export enum HookName { | |||
| 'afterEach' = 'afterEach', | |||
| } | |||
|
|
|||
| export enum DescribeProperty { | |||
There was a problem hiding this comment.
Yeah, I've just tried to be consistent with all of the rest, but you are right, it is not necessary at the moment.
|
🎉 This PR is included in version 22.13.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #340 for TypeScript as well after implementing it on #341.
The types has reminded me that I've needed to verify that the property is an identifier before accessing its name, so I've changed it as well in the js
util.