Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use messageId in all rules #278

Merged
merged 1 commit into from Jun 10, 2019
Merged

chore: use messageId in all rules #278

merged 1 commit into from Jun 10, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jun 10, 2019

Fixes #201

The TypeScript util thing forces us to use messageId anyways, so I thought to just do it now to reduce the diff when migrating to TS

@SimenB SimenB requested a review from macklinu June 10, 2019 11:23
jeysal
jeysal approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoooooly grunt work ^^ Linked it to Jest, introduced a failure, that still worked - other than that, I'll trust that you did this very carefully 😄

@SimenB SimenB merged commit 3bb50dc into master Jun 10, 2019
@SimenB SimenB deleted the message-id branch June 10, 2019 22:17
@SimenB
Copy link
Member Author

SimenB commented Jun 10, 2019

I did the rules first, so the old tests which used message verified it spit the same message out the other side. Then I did the tests. So fairly certain this is correct 🙂

@SimenB
Copy link
Member Author

SimenB commented Jun 20, 2019

🎉 This PR is included in version 22.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeysal jeysal jeysal approved these changes

@macklinu macklinu Awaiting requested review from macklinu

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use messageId in rules
2 participants
@SimenB @jeysal