New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run yarn build
during postinstall hook
#265
Conversation
yarn build
during postinstall hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not what I want, but merging to fix the issue
Thanks, and sorry about this! I don't wanna build before every test run, but I'll figure something out :) |
I thought that's what 9f40d2c should do? |
I don't want to build before every test run, since it'll slow things down. I'll probably add build to ci, and throw explicit error from eslintrc. But I'm currently in line to board a plane to Paris for react-europe, so this seems like a great quickfix in the meantime :) |
Oh, sorry, I misread. Thanks for clarification! Enjoy the conference 🎉 |
@SimenB I agree that this is not a good solution for the long term. Thanks for merging :) |
🎉 This PR is included in version 22.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I think using |
@SimenB It may be, but it still doesn't solve the local development problem. I think we should go with adding a And for local development, we should create a What do you think? |
Maybe I'm missing something, but running build during
postInstall
doesn't seem to be the right way to go.This PR moves it into
pretest
instead.Fixes #263