Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove git credentials after checkout #1281

Merged
merged 1 commit into from Nov 18, 2022
Merged

ci: remove git credentials after checkout #1281

merged 1 commit into from Nov 18, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Nov 8, 2022

This PR removes Git credentials/SSH keys after checkout as a security precaution by setting persist-credentials to false, they are not used after the initial checkout.

Due to git being used in the docs job in the nodejs workflow, it has not been removed there:

run: |
git diff --name-only \
| xargs -I '{}' bash -c \
'echo "::error file={}::This needs to be regenerated by running \`tools:regenerate-docs\`" && false'

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

@SimenB SimenB merged commit 69cebe8 into jest-community:main Nov 18, 2022
@Fdawgs Fdawgs deleted the ci/git-credentials branch November 18, 2022 09:51
@github-actions
Copy link

🎉 This PR is included in version 27.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants