Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefer-to-be): support negative numbers #1260

Merged

Conversation

hekystyle
Copy link
Contributor

Hello,

I felt like prefer-to-be rule should support also negative numbers so I tried to implement it. I will be glad for feedback and improvement suggestions. I'm also not sure if it's feature or bug.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sensible to me! I'm not getting a button for triggering CI for some reason... Might be due to bad plane wifi.

@G-Rath G-Rath changed the title feat: prefer-to-be for negative number fix(prefer-to-be): support negative numbers Oct 5, 2022
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this is a bug 😅

@G-Rath G-Rath force-pushed the prefer-to-be-for-negative-number branch from e667145 to 1fc5508 Compare October 5, 2022 17:26
@G-Rath
Copy link
Collaborator

G-Rath commented Oct 5, 2022

Weird, CI seems to be stuck even after I pushed a brand new commit ah GHA is having an incident

@G-Rath G-Rath merged commit 557dd39 into jest-community:main Oct 5, 2022
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
## [27.1.1](v27.1.0...v27.1.1) (2022-10-05)

### Bug Fixes

* **prefer-to-be:** support negative numbers ([#1260](#1260)) ([557dd39](557dd39))
@hekystyle hekystyle deleted the prefer-to-be-for-negative-number branch November 26, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants