chore: use @tsconfig/node14 and stricter TS config
#1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
changed the title
@tsconfig/node14 and stricter TS config
|
🎉 This PR is included in version 27.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
G-Rath
reviewed
Sep 11, 2022
| "noEmit": true, | ||
| "importsNotUsedAsValues": "error", |
There was a problem hiding this comment.
Curious why this? I can live with it, but my understanding is that its "maybe" needed in some rare cases (e.g. using something that isn't smart enough to automatically figure it out like tsc and Babel can), and it means extra noise in diffs when you need to switch between imports.
I'm pretty sure it doesn't help us as I've looked at our compiled outside in the past and feel this is the sort of thing I'd have done already if I found it was adding unneeded imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1226 fails CI due to "missing"
flatMap- instead of manually defininglibetc., extending@tsconfig/node14seems cleaner