Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-jest-import): remove rule #1220

Merged
merged 1 commit into from Aug 28, 2022
Merged

feat(no-jest-import): remove rule #1220

merged 1 commit into from Aug 28, 2022

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Aug 27, 2022

Resolves #1169

It's no longer true to be saying "Don't import jest" since we've got @jest/globals, and importing from the jest package specifically won't ever work in the way this rule suggests people might think it will, which'll be pretty obvious; there's also nothing stopping us from reusing the rule name in future.

BREAKING CHANGE: removed `no-jest-import` rule
@G-Rath G-Rath requested a review from SimenB August 27, 2022 20:36
@SimenB SimenB merged commit 918873b into next Aug 28, 2022
@SimenB SimenB deleted the remove-jest-import branch August 28, 2022 09:47
github-actions bot pushed a commit that referenced this pull request Aug 28, 2022
# [27.0.0-next.2](v27.0.0-next.1...v27.0.0-next.2) (2022-08-28)

### Bug Fixes

* **unbound-method:** don't suppress errors from base rule ([#1219](#1219)) ([7c1389e](7c1389e))

### Features

* make `no-alias-methods` recommended ([#1221](#1221)) ([914b24a](914b24a))
* **no-jest-import:** remove rule ([#1220](#1220)) ([918873b](918873b))
* **no-restricted-matchers:** match based on start of chain, requiring each permutation to be set ([#1218](#1218)) ([f4dd97a](f4dd97a))

### BREAKING CHANGES

* `no-alias-methods` is now recommended as the methods themselves will be removed in the next major version of Jest
* **no-jest-import:** removed `no-jest-import` rule
* **unbound-method:** errors thrown by the `unbound-method` base rule are no longer suppressed - really this means that if you don't specify `project` when this rule is enabled and `@typescript-eslint/eslint-plugin` is present, that error will no longer be suppressed instead of silently doing nothing; it will still not throw if this rule is enabled without the base rule being present
* **no-restricted-matchers:** `no-restricted-matchers` now checks against the start of the expect chain, meaning you have to explicitly list each possible matcher & modifier permutations that you want to restrict
@github-actions
Copy link

🎉 This PR is included in version 27.0.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Aug 28, 2022
# [27.0.0](v26.9.0...v27.0.0) (2022-08-28)

### Bug Fixes

* **unbound-method:** don't suppress errors from base rule ([#1219](#1219)) ([7c1389e](7c1389e))

### Features

* drop support for `eslint@6` ([#1212](#1212)) ([21fc2fe](21fc2fe))
* drop support for Node versions 12 and 17 ([#1211](#1211)) ([4c987f5](4c987f5))
* make `no-alias-methods` recommended ([#1221](#1221)) ([914b24a](914b24a))
* **no-jest-import:** remove rule ([#1220](#1220)) ([918873b](918873b))
* **no-restricted-matchers:** match based on start of chain, requiring each permutation to be set ([#1218](#1218)) ([f4dd97a](f4dd97a))

### BREAKING CHANGES

* `no-alias-methods` is now recommended as the methods themselves will be removed in the next major version of Jest
* **no-jest-import:** removed `no-jest-import` rule
* **unbound-method:** errors thrown by the `unbound-method` base rule are no longer suppressed - really this means that if you don't specify `project` when this rule is enabled and `@typescript-eslint/eslint-plugin` is present, that error will no longer be suppressed instead of silently doing nothing; it will still not throw if this rule is enabled without the base rule being present
* **no-restricted-matchers:** `no-restricted-matchers` now checks against the start of the expect chain, meaning you have to explicitly list each possible matcher & modifier permutations that you want to restrict
* Support for ESLint version 6 is removed
* Node versions 12 and 17 are no longer supported
@github-actions
Copy link

🎉 This PR is included in version 27.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jkoenig134 added a commit to js-soft/ts-linting that referenced this pull request Sep 13, 2022
jkoenig134 added a commit to js-soft/ts-linting that referenced this pull request Sep 13, 2022
* chore: bump libs

* chore: set version to 1.6.1

* chore: remove jest rule

jest-community/eslint-plugin-jest#1220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants