Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add smoke test workflow #1000

Merged
merged 1 commit into from Dec 26, 2021
Merged

ci: add smoke test workflow #1000

merged 1 commit into from Dec 26, 2021

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Dec 26, 2021

Came across this when picking up work for eslint-plugin-jest-dom - seems like a pretty cool thing to have for us too.

@G-Rath G-Rath requested a review from SimenB December 26, 2021 04:41
@G-Rath G-Rath closed this Dec 26, 2021
@G-Rath G-Rath reopened this Dec 26, 2021
@G-Rath G-Rath merged commit 4fe66ce into main Dec 26, 2021
@G-Rath G-Rath deleted the add-smoke-testing branch December 26, 2021 04:55
with:
node-version: 16
- run: |
npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Npm?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can't get yarn link working - happy if you want to have a crack at it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yarn had some issues to get package linking working across host and docker container. Same issues were seen with older npm versions: jsx-eslint/eslint-plugin-react#3120 (comment).

- uses: AriPerkkio/eslint-remote-tester-run-action@v2
with:
issue-title: 'Results of weekly scheduled smoke test'
eslint-remote-tester-config: smoke-test/eslint-remote-tester.config.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing?

@G-Rath
Copy link
Collaborator Author

G-Rath commented Dec 26, 2021

@SimenB yeah I merged this by mistake 😅 have fixed in #1003

@github-actions
Copy link

🎉 This PR is included in version 25.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants